Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

rebar_require_vsn has no ignore or force option. #319

Closed
archaelus opened this Issue · 5 comments

3 participants

@archaelus

"ERROR: OTP release 18 does not match required regex R15|R16|17"

When library authors incorrectly predict that a future OTP version will be incompatible with their code, it is exceedingly inconvenient not to have a way to turn the Erts, OTP version restrictions into warnings rather than fatal errors.

I encounter this fairly often as I usually do development with git master Erlang so am a version ahead of released OTP. Modifying the rebar.config files is not a useful solution as these restrictions are often embedded in dependencies too.

I propose that we add an option for rebar_require_vsn that turns the ?ABORT into a ?WARN and allows compilation to continue. Perhaps the existing -k or -f rebar options could have this effect?

@ferd ferd added the enhancement label
@tuncer

Sounds reasonable to me, should be a simple patch.

@tuncer

@archaelus how about turning the ERROR into a WARN message and continue?

@archaelus

Yep - works for me. Are we talking about leaving the current ?ABORT and converting that to ?WARN if the flag is present, or dropping the current abort behaviour and making it always warn instead (i.e. unconditionally make the error non-fatal)? I like either but was proposing the former.

@tuncer

If the flag is present, it'll call ?WARN and not ?ABORT.

@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -f is passed
Fixes #319.
b903b36
@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -f is passed
Fixes #319.
678bf10
@tuncer

Here's a patch: #322.

@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -f is passed
Fixes #319.
085e3c0
@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -k/--keep-going
Fixes #319.
fc6625a
@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -k/--keep-going
Fixes #319.
f95e4ae
@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -k/--keep-going
Fixes #319.
f604b92
@tuncer tuncer referenced this issue from a commit in tuncer/rebar
@tuncer tuncer Treat vsn mismatch as warning if -k/--keep-going
Fixes #319.
a4c5f33
@ferd ferd closed this in #322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.