External deps_dir should have higher priority than the config one #100

Merged
merged 1 commit into from Jun 17, 2013

Conversation

Projects
None yet
2 participants
Contributor

josevalim commented Jun 17, 2013

The external deps_dir should have higher priority because
it is used by scripts and other build tools to set up the
location of the dependencies. This commit ensures that,
even if a project has set deps_dir in its config file has
lower preference than the command line one.

External deps_dir should have higher priority than the config one
The external deps_dir should have higher priority because
it is used by scripts and other build tools to set up the
location of the dependencies. This commit ensures that,
even if a project has set deps_dir in its config file has
lower preference than the command line one.
Owner

dizzyd commented Jun 17, 2013

I'm going to merge this PR, because I think it's right that the global should override local for this variable, but am fully aware that rebar is not consistent in all cases with this. :)

dizzyd added a commit that referenced this pull request Jun 17, 2013

Merge pull request #100 from josevalim/patch-1
External deps_dir should have higher priority than the config one

@dizzyd dizzyd merged commit 3a95596 into rebar:master Jun 17, 2013

1 check passed

default The Travis CI build passed
Details

@josevalim josevalim deleted the josevalim:patch-1 branch Jun 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment