This repository has been archived by the owner. It is now read-only.

Some optimisation/refactoring using stdlib's functions #171

Merged
merged 2 commits into from Jun 14, 2014

Conversation

Projects
None yet
4 participants
@fenollp
Contributor

fenollp commented Nov 22, 2013

No description provided.

@fenollp

This comment has been minimized.

Show comment
Hide comment
@fenollp

fenollp Dec 16, 2013

Contributor

Tarvis build fails because of an unrelated syntax error in inttest/tplugins/tplugins_rt.erl

Contributor

fenollp commented Dec 16, 2013

Tarvis build fails because of an unrelated syntax error in inttest/tplugins/tplugins_rt.erl

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Dec 16, 2013

Contributor

What syntax error are you referring to? I can only see the rgen1_rt timeout, which is fixed by #189 and #190.

Contributor

tuncer commented Dec 16, 2013

What syntax error are you referring to? I can only see the rgen1_rt timeout, which is fixed by #189 and #190.

@fenollp

This comment has been minimized.

Show comment
Hide comment
@fenollp

fenollp Dec 16, 2013

Contributor

I was referred to this error

Contributor

fenollp commented Dec 16, 2013

I was referred to this error

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Dec 16, 2013

Contributor

That's a deliberate syntax error and part of the test, and the travis-ci job you linked to actually succeeded completely. The real cause for the failed job is that rgen1_rt often requires more time to run than the default retest timeout of 30 seconds. @jaredmorrow, I suggest to merge #190 and #129 and review this patch again after a rebase. What do you think?

Contributor

tuncer commented Dec 16, 2013

That's a deliberate syntax error and part of the test, and the travis-ci job you linked to actually succeeded completely. The real cause for the failed job is that rgen1_rt often requires more time to run than the default retest timeout of 30 seconds. @jaredmorrow, I suggest to merge #190 and #129 and review this patch again after a rebase. What do you think?

@Vagabond

This comment has been minimized.

Show comment
Hide comment
@Vagabond

Vagabond Mar 5, 2014

Contributor

Please re-base, if any of this is still applicable.

Contributor

Vagabond commented Mar 5, 2014

Please re-base, if any of this is still applicable.

@fenollp

This comment has been minimized.

Show comment
Hide comment
@fenollp

fenollp Mar 9, 2014

Contributor

I finally managed to get rebase -i right, was using it the other way…

Contributor

fenollp commented Mar 9, 2014

I finally managed to get rebase -i right, was using it the other way…

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer May 29, 2014

Contributor

Is there anything holding up a merge?

Contributor

tuncer commented May 29, 2014

Is there anything holding up a merge?

@tsloughter

This comment has been minimized.

Show comment
Hide comment
@tsloughter

tsloughter Jun 12, 2014

Member

Needs a rebase again.

Member

tsloughter commented Jun 12, 2014

Needs a rebase again.

fenollp added some commits Nov 22, 2013

Local corrections on string processing:
* Corrected regexp: `[x|y]` -> `[xy]`.
* Used an re:replace/4 option instead of multiple IOlist functions.
@fenollp

This comment has been minimized.

Show comment
Hide comment
@fenollp

fenollp Jun 13, 2014

Contributor

Rebased.

Contributor

fenollp commented Jun 13, 2014

Rebased.

tsloughter added a commit that referenced this pull request Jun 14, 2014

Merge pull request #171 from fenollp/using-stdlib
Some optimisation/refactoring using stdlib's functions

@tsloughter tsloughter merged commit 3297ffe into rebar:master Jun 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@fenollp fenollp deleted the fenollp:using-stdlib branch Jun 14, 2014

tsloughter added a commit that referenced this pull request Jun 14, 2014

Revert "Merge pull request #171 from fenollp/using-stdlib"
This reverts commit 3297ffe, reversing
changes made to 0401deb.
@tsloughter

This comment has been minimized.

Show comment
Hide comment
@tsloughter

tsloughter Jun 14, 2014

Member

@fenollp this actually broke rebar eunit

ERROR: eunit failed while processing ....: {'EXIT',{badarg,[{io,format,
[standard_error,"ERROR: Failed to delete file ~s: ~pn",
[46,badarg]],
[]},

So I had to revert the merge.

Member

tsloughter commented Jun 14, 2014

@fenollp this actually broke rebar eunit

ERROR: eunit failed while processing ....: {'EXIT',{badarg,[{io,format,
[standard_error,"ERROR: Failed to delete file ~s: ~pn",
[46,badarg]],
[]},

So I had to revert the merge.

@fenollp fenollp restored the fenollp:using-stdlib branch Jun 14, 2014

@fenollp

This comment has been minimized.

Show comment
Hide comment
@fenollp

fenollp Jun 19, 2014

Contributor

@tsloughter I'm sorry I can't reproduce this error.

However with make check I get

make: [dialyzer_warnings] Error 1 (ignored)
--- dialyzer_reference  2014-06-19 15:00:09.000000000 +0200
+++ dialyzer_warnings   2014-06-19 15:00:30.000000000 +0200
@@ -2,2 +2,2 @@
-rebar_eunit.erl:434: Call to missing or unexported function eunit_test:function_wrapper/2
-rebar_utils.erl:164: Call to missing or unexported function escript:foldl/3
+dialyzer: Old PLT file /Users/pete/.dialyzer_plt
+

and rebar eunit

ERROR: Cannot parse eunit version string:
ERROR: Cannot parse eunit version string: abc
rebar_file_utils_tests:194: cp_r_overwrite_file_fail_test_...*failed*
in function rebar_file_utils_tests:'-cp_r_overwrite_file_fail_test_/0-fun-2-'/0 (test/rebar_file_utils_tests.erl, line 194)
**error:{assertException_failed,
    [{module,rebar_file_utils_tests},
     {line,194},
     {expression,
         "rebar_file_utils : cp_r ( [ filename : join ( [ ? TMP_DIR , \"source\" , \"file1\" ] ) ] , filename : join ( [ ? TMP_DIR , \"dest\" ] ) )"},
     {pattern,"{ throw , rebar_abort , [...] }"},
     {unexpected_exception,
         {error,
             {badmatch,{error,{1,[99,112|...]}}},
             [{rebar_file_utils,cp_r,2,[{file,...},{...}]},
              {rebar_file_utils_tests,
                  '-cp_r_overwrite_file_fail_test_/0-fun-2-',0,
                  [{...}|...]},
              {eunit_test,run_testfun,1,[...]},
              {eunit_proc,run_test,1,...},
              {eunit_proc,with_timeout,...},
              {eunit_proc,...},
              {...}|...]}}]}


rebar_file_utils_tests:213: cp_r_overwrite_dir_fail_test_...*failed*
in function rebar_file_utils_tests:'-cp_r_overwrite_dir_fail_test_/0-fun-2-'/0 (test/rebar_file_utils_tests.erl, line 213)
**error:{assertException_failed,
    [{module,rebar_file_utils_tests},
     {line,213},
     {expression,
         "rebar_file_utils : cp_r ( [ filename : join ( [ ? TMP_DIR , \"source\" ] ) ] , filename : join ( [ ? TMP_DIR , \"dest\" ] ) )"},
     {pattern,"{ throw , rebar_abort , [...] }"},
     {unexpected_exception,
         {error,
             {badmatch,{error,{1,[99,112|...]}}},
             [{rebar_file_utils,cp_r,2,[{file,...},{...}]},
              {rebar_file_utils_tests,
                  '-cp_r_overwrite_dir_fail_test_/0-fun-2-',0,
                  [{...}|...]},
              {eunit_test,run_testfun,1,[...]},
              {eunit_proc,run_test,1,...},
              {eunit_proc,with_timeout,...},
              {eunit_proc,...},
              {...}|...]}}]}


=======================================================
  Failed: 2.  Skipped: 0.  Passed: 109.
ERROR: One or more eunit tests failed.

And that's on either my (this) branch or master.
Do you know what's going on?

Contributor

fenollp commented Jun 19, 2014

@tsloughter I'm sorry I can't reproduce this error.

However with make check I get

make: [dialyzer_warnings] Error 1 (ignored)
--- dialyzer_reference  2014-06-19 15:00:09.000000000 +0200
+++ dialyzer_warnings   2014-06-19 15:00:30.000000000 +0200
@@ -2,2 +2,2 @@
-rebar_eunit.erl:434: Call to missing or unexported function eunit_test:function_wrapper/2
-rebar_utils.erl:164: Call to missing or unexported function escript:foldl/3
+dialyzer: Old PLT file /Users/pete/.dialyzer_plt
+

and rebar eunit

ERROR: Cannot parse eunit version string:
ERROR: Cannot parse eunit version string: abc
rebar_file_utils_tests:194: cp_r_overwrite_file_fail_test_...*failed*
in function rebar_file_utils_tests:'-cp_r_overwrite_file_fail_test_/0-fun-2-'/0 (test/rebar_file_utils_tests.erl, line 194)
**error:{assertException_failed,
    [{module,rebar_file_utils_tests},
     {line,194},
     {expression,
         "rebar_file_utils : cp_r ( [ filename : join ( [ ? TMP_DIR , \"source\" , \"file1\" ] ) ] , filename : join ( [ ? TMP_DIR , \"dest\" ] ) )"},
     {pattern,"{ throw , rebar_abort , [...] }"},
     {unexpected_exception,
         {error,
             {badmatch,{error,{1,[99,112|...]}}},
             [{rebar_file_utils,cp_r,2,[{file,...},{...}]},
              {rebar_file_utils_tests,
                  '-cp_r_overwrite_file_fail_test_/0-fun-2-',0,
                  [{...}|...]},
              {eunit_test,run_testfun,1,[...]},
              {eunit_proc,run_test,1,...},
              {eunit_proc,with_timeout,...},
              {eunit_proc,...},
              {...}|...]}}]}


rebar_file_utils_tests:213: cp_r_overwrite_dir_fail_test_...*failed*
in function rebar_file_utils_tests:'-cp_r_overwrite_dir_fail_test_/0-fun-2-'/0 (test/rebar_file_utils_tests.erl, line 213)
**error:{assertException_failed,
    [{module,rebar_file_utils_tests},
     {line,213},
     {expression,
         "rebar_file_utils : cp_r ( [ filename : join ( [ ? TMP_DIR , \"source\" ] ) ] , filename : join ( [ ? TMP_DIR , \"dest\" ] ) )"},
     {pattern,"{ throw , rebar_abort , [...] }"},
     {unexpected_exception,
         {error,
             {badmatch,{error,{1,[99,112|...]}}},
             [{rebar_file_utils,cp_r,2,[{file,...},{...}]},
              {rebar_file_utils_tests,
                  '-cp_r_overwrite_dir_fail_test_/0-fun-2-',0,
                  [{...}|...]},
              {eunit_test,run_testfun,1,[...]},
              {eunit_proc,run_test,1,...},
              {eunit_proc,with_timeout,...},
              {eunit_proc,...},
              {...}|...]}}]}


=======================================================
  Failed: 2.  Skipped: 0.  Passed: 109.
ERROR: One or more eunit tests failed.

And that's on either my (this) branch or master.
Do you know what's going on?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.