This repository has been archived by the owner. It is now read-only.

List support for doc_root and source_ext options. #257

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@glejeune

glejeune commented Apr 5, 2014

doc_root and source_ext can now receive lists as parameters. This is
particularly useful when using ErlyDTL if you want to have multiple
extensions (.html, .xml, ...) in many locations. Example :

{erlydtl opts, [
    {doc_root, ["xml", "html"]},
    {source_ext, [".xml", ".html"]},
]}.

Note that the current format (with just a string) is still supported.

List support for doc_root and source_ext options.
doc_root and source_ext can now receive lists as parameters. This is
particularly useful when using ErlyDTL if you want to have multiple
extensions (.html, .xml, ...) in many locations. Example :

    {erlydtl opts, [
        {doc_root, ["xml", "html"]},
        {source_ext, [".xml", ".html"]},
    ]}.

Note that the current format (with just a string) is still supported.
@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer May 29, 2014

Contributor

Not sure about this, but before it can be merged, it's best to extend at least eunit and erlc tests and document the new feature. Also, the changes in rebar_base_compiler.erl should be formatted with erlang.el (erlang-mode).

Contributor

tuncer commented May 29, 2014

Not sure about this, but before it can be merged, it's best to extend at least eunit and erlc tests and document the new feature. Also, the changes in rebar_base_compiler.erl should be formatted with erlang.el (erlang-mode).

+ lists:foldl(fun({SourceDir1, SourceExt1}, _) ->
+ run_(Config, FirstFiles, SourceDir1, SourceExt1,
+ TargetDir, TargetExt, Compile3Fn, Opts)
+ end, ok, [{D, E} || D <- ListDir, E <- ListExt]).

This comment has been minimized.

@tuncer

tuncer May 29, 2014

Contributor

If you want to ignore the result of the lists:foldl call, please change it to _ = lists:foldl.

@tuncer

tuncer May 29, 2014

Contributor

If you want to ignore the result of the lists:foldl call, please change it to _ = lists:foldl.

@ferd ferd added the enhancement label Jun 16, 2014

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Apr 2, 2015

Contributor

ping?

Contributor

tuncer commented Apr 2, 2015

ping?

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer May 12, 2015

Contributor

ping?

Contributor

tuncer commented May 12, 2015

ping?

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Jun 1, 2015

Contributor

ping?

Contributor

tuncer commented Jun 1, 2015

ping?

@ferd

This comment has been minimized.

Show comment
Hide comment
@ferd

ferd Jun 1, 2015

Contributor

This is obviously dead. 1 year since the last involvement of the author, over a month of pings. Closing. If anything else comes up, we'll reopen and handle it.

Contributor

ferd commented Jun 1, 2015

This is obviously dead. 1 year since the last involvement of the author, over a month of pings. Closing. If anything else comes up, we'll reopen and handle it.

@ferd ferd closed this Jun 1, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.