This repository has been archived by the owner on May 12, 2018. It is now read-only.
Allow behaviors defined inside xref_extra_path #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with this change. Could we have a test to go with it? See https://github.com/rebar/rebar/blob/master/CONTRIBUTING.md |
|
Thanks for your feedback, Fred. I'll try to have a test case ready soon (not this weekend though) that illustrates the desired behavior (should I have one for success and another for non-success?) and then ammend my commit. |
|
Success alone should be good enough. |
|
I updated the pull request. Created only one test case for retest, which illustrates the expected behavior. |
Use case: xref'ing a module that defined behavior ranch_protocol was
exiting with
{'EXIT',{undef,[{ranch_protocol,behaviour_info, [callbacks],[]}
ferd
added a commit
that referenced
this pull request
Aug 21, 2015
…behaviors Allow behaviors defined inside xref_extra_path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: xref'ing a module that defined behavior ranch_protocol was
exiting with
{'EXIT',{undef,[{ranch_protocol,behaviour_info, [callbacks],[]}