Skip to content
This repository has been archived by the owner on May 12, 2018. It is now read-only.

Fix eunit test on OTP18 #537

Merged
merged 1 commit into from Aug 24, 2015
Merged

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Aug 24, 2015

OTP18 changed the output failed assertion string
from assertEqual_failed to assertEqual

OTP18 changed the output failed assertion string
from assertEqual_failed to assertEqual
@ferd
Copy link
Contributor

ferd commented Aug 24, 2015

If I get the tests right, this works in old versions because we match on a partial string and assertEqual still matches assertEqual_failed? This does seem a bit brittle (it would match on assertEqual_success) but fine by me.

@lrascao
Copy link
Contributor Author

lrascao commented Aug 24, 2015

luckily there's no assertEqual_success but i see your point, the actual string that is being returned is:
**error:{assertEqual_failed,[{module,myapp_mymod3},
{line,8},
{expression,"false"},
{expected,true},
{value,false}]}

ideally we should be able to parse the whole string into an erlang term and match that, much safer that way

@ferd
Copy link
Contributor

ferd commented Aug 24, 2015

Agreed. for the time being this is fine, though.

ferd added a commit that referenced this pull request Aug 24, 2015
@ferd ferd merged commit 0f78c60 into rebar:master Aug 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants