This repository has been archived by the owner. It is now read-only.

Add support for versioning in dependency name #87

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@lafka

lafka commented May 9, 2013

Pick the dependency version by wildcard, then filter it by #dep.vsn_regex
The highest number will be picked or with fallback to app name (<depsdir>/#dep.app).

Motivation for this are cases where rebar does not have sole responsibility
for managing and building dependencies and a the stricter -
format is used for dependencies.

Add support for versioning in dependency name
Pick the dependency version by wildcard, then filter it by #dep.vsn_regex
The highest number will be picked or with fallback to app name (`<depsdir>/#dep.app`).

Motivation for this are cases where rebar does not have sole responsibility
for managing and building dependencies and a the stricter <app>-<vsn>
format is used for dependencies.
@dizzyd

This comment has been minimized.

Show comment
Hide comment
@dizzyd

dizzyd Jun 17, 2013

Member

@lafka - I'm curious, if rebar isn't managing the deps, what is? Also, if something else is managing the deps, why not just have it do this work?

Member

dizzyd commented Jun 17, 2013

@lafka - I'm curious, if rebar isn't managing the deps, what is? Also, if something else is managing the deps, why not just have it do this work?

@lafka

This comment has been minimized.

Show comment
Hide comment
@lafka

lafka Jun 19, 2013

@dizzyd In this instance i'm using EPM to manage the deps. Rebar is in some cases used for compilation/release generation, which is something EPM will never do.

lafka commented Jun 19, 2013

@dizzyd In this instance i'm using EPM to manage the deps. Rebar is in some cases used for compilation/release generation, which is something EPM will never do.

@tsloughter

This comment has been minimized.

Show comment
Hide comment
@tsloughter

tsloughter Feb 9, 2014

Member

+1

I just ran into this setting up Nix to handle creating dev environments for Erlang projects and needing to tell rebar where the deps are. I see no reason to not support -.

Member

tsloughter commented Feb 9, 2014

+1

I just ran into this setting up Nix to handle creating dev environments for Erlang projects and needing to tell rebar where the deps are. I see no reason to not support -.

@jaredmorrow

This comment has been minimized.

Show comment
Hide comment
@jaredmorrow

jaredmorrow Mar 5, 2014

Contributor

This PR is interesting, but for it to move forward (if you are interested still), I need to see some documentation added, both to the help page and sample rebar.config. Tests added to inttest would also make it easier to reason with.

If there is no longer a need (since EPM looks dead), let me know and I can close it.

Contributor

jaredmorrow commented Mar 5, 2014

This PR is interesting, but for it to move forward (if you are interested still), I need to see some documentation added, both to the help page and sample rebar.config. Tests added to inttest would also make it easier to reason with.

If there is no longer a need (since EPM looks dead), let me know and I can close it.

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Mar 5, 2014

Contributor

Wouldn't it better to implement a real constraint (sat) solver (see #240).

Contributor

tuncer commented Mar 5, 2014

Wouldn't it better to implement a real constraint (sat) solver (see #240).

@lafka

This comment has been minimized.

Show comment
Hide comment
@lafka

lafka Mar 7, 2014

@jaredmorrow EPM is currently not maintained, so no requirement from my side.
@tuncer I would like to see that as well.

If there is an interest to merge this I can add the documentation and tests.

lafka commented Mar 7, 2014

@jaredmorrow EPM is currently not maintained, so no requirement from my side.
@tuncer I would like to see that as well.

If there is an interest to merge this I can add the documentation and tests.

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Mar 10, 2014

Contributor

@lafka if we merge this now and add a real solver later, what would it mean for the features introduced in this patch?

Contributor

tuncer commented Mar 10, 2014

@lafka if we merge this now and add a real solver later, what would it mean for the features introduced in this patch?

@lafka

This comment has been minimized.

Show comment
Hide comment
@lafka

lafka Mar 10, 2014

@tuncer assuming #240 allows you to have multiple copies of a dependency (with different version), this PR would not provide any new features.

I don't think there is a an urgent need for this feature so if #240 or basho/rebar#263 gets merged in the future I can close this.

lafka commented Mar 10, 2014

@tuncer assuming #240 allows you to have multiple copies of a dependency (with different version), this PR would not provide any new features.

I don't think there is a an urgent need for this feature so if #240 or basho/rebar#263 gets merged in the future I can close this.

@tuncer

This comment has been minimized.

Show comment
Hide comment
@tuncer

tuncer Mar 10, 2014

Contributor

@lafka so we should probably bring the various efforts together and avoid introducing similar but not combinable features.

Contributor

tuncer commented Mar 10, 2014

@lafka so we should probably bring the various efforts together and avoid introducing similar but not combinable features.

@tsloughter tsloughter closed this Jun 15, 2014

@ferd

This comment has been minimized.

Show comment
Hide comment
@ferd

ferd Jun 15, 2014

Contributor

Hi, this issue was closed in an attempt to do quick basic filtering, with the benediction of rebar project owners. These issues and pull requests are not issues or code we're spitting on, but given the burden of the task and how much code rot may have happened since these were open is unknown from maintainers at this time. All tickets prior to March 2014 were closed and will be reopened on a per-request basis if we see interest from the reporter or contributor, or if some of the issues reported are still valid after the various patches that have made it since they were opened.

This is a fairly brutal first step to help us get a proper understanding of what is still valid or not, but that has been proven efficient in the past. Sorry for the inconvenience, things should go smoother from there on.

Contributor

ferd commented Jun 15, 2014

Hi, this issue was closed in an attempt to do quick basic filtering, with the benediction of rebar project owners. These issues and pull requests are not issues or code we're spitting on, but given the burden of the task and how much code rot may have happened since these were open is unknown from maintainers at this time. All tickets prior to March 2014 were closed and will be reopened on a per-request basis if we see interest from the reporter or contributor, or if some of the issues reported are still valid after the various patches that have made it since they were opened.

This is a fairly brutal first step to help us get a proper understanding of what is still valid or not, but that has been proven efficient in the past. Sorry for the inconvenience, things should go smoother from there on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.