Add test case for relx overlay vars #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lrascao overlay vars have to be iolists. Maybe the solution to the issue is for relx to throw an error if a overlay var isn't an iolist? |
lrascao
force-pushed
the
fix/relx_overlay_vars
branch
from
a86b5f5
to
1f3140f
Compare
Closed
Makes use of several var types: integers, strings, binaries, binary strings and tuples.
lrascao
force-pushed
the
fix/relx_overlay_vars
branch
from
1f3140f
to
f60c522
Compare
|
Test case updated, vars are now iolists |
|
Awesome, thanks. |
tsloughter
added a commit
that referenced
this pull request
Feb 6, 2016
Add test case for relx overlay vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test case for validation against #1036, so it's failing right now.
It also exposes erlware/relx#335, to reproduce it run the test then enter the directory where the test fixtures were generated to and generate the release again, if run multiple times it will fail with the
error every other time.
This is relx erroring out because it's trying to rewrite OTP's kernel .app file which is not present, it seems to be copied in one run and deleted in the next, this accounts for it failing every other time
Makes use of several var types: integers,
strings, binaries, binary strings and tuples.