New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe 2.0.0 released, updated dependencies #410

Closed
cannikin opened this Issue Feb 21, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@cannikin
Contributor

cannikin commented Feb 21, 2017

Stripe released version 2.0.0 of the gem recently with the following changes:

  • Drop support for Ruby 1.9
  • Allow HTTP client that makes Stripe calls to be configured via Faraday
  • Drop RestClient
  • Switch to OpenAPI 2.0 spec and generated fixtures in test suite
  • Switch to Webmock in test suite

stripe-ruby-mock has us locked into ~> 1.31. Any plans to update that dependency? If the 1.9 support is a concern maybe fork the current version of this gem and have it retain 1.9 support while this one moves forward with the stripe gem itself?

@thiagoramos23

This comment has been minimized.

thiagoramos23 commented Mar 9, 2017

Is anyone getting this so I can help?

@nfm

This comment has been minimized.

Contributor

nfm commented Mar 9, 2017

One reason the stripe gem switched to Faraday is to make adding request/response middleware easier. So stripe-ruby-mock could hook into attempted HTTP requests and return data in a much nicer way. I think that would be a pretty significant rewrite of how this gem works internally though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment