Skip to content

Conversation

@ddeath
Copy link
Contributor

@ddeath ddeath commented Aug 31, 2018

Hi I found that this package is not working on php 7.2 because it will throw an error:

local.ERROR: ErrorException: count(): Parameter must be an array or an object that implements Countable in .../vendor/rebing/graphql-laravel/src/Rebing/GraphQL/GraphQLController.php:21

The reason why this happen is that on php 7.1 will count behave different:

count(NULL); // 0

but on php 7.2:

count(NULL); // PHP Warning:  count(): Parameter must be an array or an object that implements Countable 

@rebing rebing merged commit 00636c4 into rebing:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants