Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 7 support #597

Merged
merged 13 commits into from
Mar 7, 2020
Merged

Add Laravel 7 support #597

merged 13 commits into from
Mar 7, 2020

Conversation

exodusanto
Copy link
Contributor

@exodusanto exodusanto commented Feb 28, 2020

Summary

Update illuminate/support version


🥶Waiting for Laravel 7 release => released!

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry

@exodusanto exodusanto changed the title Add illuminate 7.0 support Add Laravel 7 support Feb 28, 2020
@exodusanto exodusanto changed the title Add Laravel 7 support [Pending] Add Laravel 7 support Feb 28, 2020
@mfn
Copy link
Collaborator

mfn commented Feb 28, 2020

I love the composer output when it has version problems 😅

Likely orechstra needs to be bumped!

@exodusanto
Copy link
Contributor Author

Yes, today the branch 5.x-dev is updated with Laravel 7 but it has not yet been released yet orchestra/testbench

@mfn
Copy link
Collaborator

mfn commented Feb 28, 2020

kk and thanks for the initiative, much appreciated 🙏

@mfn mfn added the blocked label Feb 28, 2020
@mfn
Copy link
Collaborator

mfn commented Mar 3, 2020

Tried to retrigger jobs but still fails :-(

@mfn mfn mentioned this pull request Mar 3, 2020
9 tasks
@exodusanto
Copy link
Contributor Author

The new branch of orchestra/testbench is 5.*

@exodusanto exodusanto changed the title [Pending] Add Laravel 7 support Add Laravel 7 support Mar 3, 2020
@exodusanto

This comment has been minimized.

@exodusanto

This comment has been minimized.

@mfn mfn removed the blocked label Mar 3, 2020
@johanzandstra
Copy link

@exodusanto Thanks for your effort! Can this be merged in the master so we can update to Laravel 7? What are the expected timelines for this?

@exodusanto
Copy link
Contributor Author

If you need to test locally Laravel 7 in the meanwhile you can use my fork dev-master as a vcs on composer

@mfn
Copy link
Collaborator

mfn commented Mar 5, 2020

I'm busy ATM, will review & merge ASAP => sorry!

Comment on lines +420 to +424
$error = new \Exception(
$error->getMessage(),
$error->getCode(),
$error
);
Copy link
Contributor Author

@exodusanto exodusanto Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrapped the error with the Exception class to be backward-compatibile with Laravel <= 6.x.
I had to remove the FatalThrowableError because it doesn't exist anymore on Symfony 5

@StringKe
Copy link

StringKe commented Mar 6, 2020

If you need to test locally Laravel 7 in the meanwhile you can use my fork dev-master as a vcs on composer

I tried to load this way, and there was a bit of error. Do you know what the problem is?

{
"repositories": {
        "graphql-laravel": {
            "type": "package",
            "package": {
                "name": "exodusanto/graphql-laravel",
                "version": "1.0",
                "source": {
                    "url": "https://github.com/exodusanto/graphql-laravel",
                    "type": "git",
                    "reference": "origin/master"
                }
            }
        }
    }
}

image

@exodusanto
Copy link
Contributor Author

Hi @StringKe
try this:

edit your composer.json

    "require": [
        "rebing/graphql-laravel": "dev-master",
    ],
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/exodusanto/graphql-laravel"
        }
    ],

and after run composer update

@mfn mfn self-requested a review March 7, 2020 19:31
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, very much appreciated 🙇

@mfn mfn merged commit bb32622 into rebing:master Mar 7, 2020
@mfn
Copy link
Collaborator

mfn commented Mar 7, 2020

I've just released https://github.com/rebing/graphql-laravel/releases/tag/5.0.0-rc2

Since the 5.* cycle already started, I currently don't plan to revisit 4.x with Laravel 7 support

@mfn
Copy link
Collaborator

mfn commented Apr 3, 2020

https://github.com/rebing/graphql-laravel/releases/tag/5.0.0 has been released with L7 support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants