From e82725b973a550a7b2bd73c3e1ce43a66af70a9b Mon Sep 17 00:00:00 2001
From: Enrico B
Date: Fri, 1 Dec 2017 19:59:46 -0500
Subject: [PATCH] Add MRU sort settings #36
---
src/core/pages/settings/input-bindings.js | 5 +++--
src/core/reducers/defaults.js | 2 ++
src/static/settings/index.html | 12 ++++++++++++
3 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/src/core/pages/settings/input-bindings.js b/src/core/pages/settings/input-bindings.js
index 271a918..39c863a 100644
--- a/src/core/pages/settings/input-bindings.js
+++ b/src/core/pages/settings/input-bindings.js
@@ -13,6 +13,7 @@ const d = document;
const disableBindings = {
showRecentlyClosed: ['recentlyClosedLimit', 'alwaysShowRecentlyClosedAtTheBottom'],
enableFuzzySearch: ['threshold', 'shouldSort'],
+ shouldSortByMostRecentlyUsedOnPopup: ['shouldSortByMostRecentlyUsedAll'],
};
const mirrorBindings = {
threshold: 'thresholdDisplay',
@@ -31,11 +32,11 @@ export default function addInputBindings() {
const dependents = disableBindings[masterId];
dependents.forEach((dependentId) => {
const dependent = d.getElementById(dependentId);
- // Don't need strict compare
- // eslint-disable-next-line eqeqeq
dependent.disabled = !checked;
const label = d.querySelector(`label[for=${dependentId}]`);
if (!checked) {
+ dependent.checked = false;
+ dependent.dispatchEvent(new Event('change'));
label.classList.add('disabled-label');
} else {
label.classList.remove('disabled-label');
diff --git a/src/core/reducers/defaults.js b/src/core/reducers/defaults.js
index 2318e24..08c5af4 100644
--- a/src/core/reducers/defaults.js
+++ b/src/core/reducers/defaults.js
@@ -16,6 +16,8 @@ export const initialGeneralSettings = {
recentlyClosedLimit: 5,
useFallbackFont: false,
showLastQueryOnPopup: false,
+ shouldSortByMostRecentlyUsedOnPopup: false,
+ shouldSortByMostRecentlyUsedAll: false,
};
export const initialState = {
diff --git a/src/static/settings/index.html b/src/static/settings/index.html
index 9d43bda..0e7e64a 100644
--- a/src/static/settings/index.html
+++ b/src/static/settings/index.html
@@ -199,6 +199,18 @@ Search Results
Show the last query's results when opening the popup window
+
+
+
+
+
+
+
+