Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed all the empty else condition #26

Merged
merged 3 commits into from Dec 13, 2018
Merged

Conversation

@d78ui98
Copy link
Contributor

d78ui98 commented Aug 28, 2018

I made simple code optimization by removing all the empty else condition.
This can reduce the number of lines of code from 1680 to 1322

a simple code optimization that reduced the number of lines of code from 1680 to 1322
@rebootuser

This comment has been minimized.

Copy link
Owner

rebootuser commented Sep 11, 2018

This makes a lot of sense, I appreciate the work. I'll run some checks to ensure everything works as expected (can't see why it shouldn't) and will merge when verified.

@d78ui98

This comment has been minimized.

Copy link
Contributor Author

d78ui98 commented Oct 14, 2018

Sure. Feel free to run the tests :)

@rebootuser

This comment has been minimized.

Copy link
Owner

rebootuser commented Dec 12, 2018

Code has been updated since this pull (I have been slow to commit this, apologies). If you can update the request, I'll commit changes. Alternatively, I'm happy to make changes and reference your contribution.

d78ui98 added 2 commits Dec 12, 2018
updating commits
@d78ui98

This comment has been minimized.

Copy link
Contributor Author

d78ui98 commented Dec 12, 2018

@rebootuser I have updated the request and tested it.

Alternatively, I'm happy to make changes and reference your contribution.

That would be great!

@rebootuser rebootuser merged commit 196f9f2 into rebootuser:master Dec 13, 2018
@rebootuser

This comment has been minimized.

Copy link
Owner

rebootuser commented Dec 13, 2018

Merged. This is a great contribution, very much appreciate your efforts in cleaning up the code!

@d78ui98 d78ui98 deleted the d78ui98:optimize branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.