Added message timeout tracking to the ErrorTracker #73

Merged
merged 1 commit into from Mar 29, 2012

Conversation

Projects
None yet
2 participants
@ssboisen
Contributor

ssboisen commented Mar 29, 2012

When a message has been tracked for some TimeSpan the message is removed in order to ensure it doesn't leak due to the TimeToBeReceived being expired. Maybe a future change should let the timeout be dependent on the Headers.TimeToBeReceived since it doesn't really make any sense to remove error-tracking on messages which time to be received hasn't been exceeded.

Added message timeout tracking to the ErrorTracker. When a message ha…
…s been tracked for some TimeSpan the message is removed in order to ensure it doesn't leak due to the TimeToBeReceived being expired. Maybe a future change should let the timeout be dependent on the Headers.TimeToBeReceived since it doesn't really make any sense to remove error-tracking on messages which time to be received hasn't been exceeded. Issue #72
@mookid8000

This comment has been minimized.

Show comment Hide comment
@mookid8000

mookid8000 Mar 29, 2012

Owner

Given that retries will occur in very quick succession, it would probably work even with much shorter expiration on the retry tracker.

If a retry tracker were to expire before the final retry, it would mean that the message processing took almost 5 hours with 5 retries and an expiration of 24 hours. Therefore: No worries :)

Owner

mookid8000 commented Mar 29, 2012

Given that retries will occur in very quick succession, it would probably work even with much shorter expiration on the retry tracker.

If a retry tracker were to expire before the final retry, it would mean that the message processing took almost 5 hours with 5 retries and an expiration of 24 hours. Therefore: No worries :)

mookid8000 added a commit that referenced this pull request Mar 29, 2012

Merge pull request #73 from ssboisen/issue_72-errortracker_timeout
Added message timeout tracking to the ErrorTracker

@mookid8000 mookid8000 merged commit a9f3d48 into rebus-org:master Mar 29, 2012

@ssboisen

This comment has been minimized.

Show comment Hide comment
@ssboisen

ssboisen Mar 29, 2012

Contributor

Oh yeah true, while writing that I forgot a message is removed after five retries :-D

Contributor

ssboisen commented Mar 29, 2012

Oh yeah true, while writing that I forgot a message is removed after five retries :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment