This repository has been archived by the owner on Oct 5, 2020. It is now read-only.
CLOUD-2093 Abort if Argo app is found #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernhaeuser
approved these changes
Nov 4, 2019
svenwltr
reviewed
Nov 4, 2019
pkg/api/apply.go
Outdated
| appsClient := argoClient.Applications("") | ||
| _, err = appsClient.Get(project, v1.GetOptions{}) | ||
| if err != nil { | ||
| log.Warnf("failed to get argo app '%s' - legacy project", project) |
There was a problem hiding this comment.
Wouldn't that mean that we get this error message on every legacy deployment?
There was a problem hiding this comment.
I changed it to a debug message, I just want to make sure we notice any errors in the logs.
There was a problem hiding this comment.
In this case you should examine the error type and check if it is a not found error or something other.
der-eismann
force-pushed
the
abort-argo-apps
branch
from
5c26a95
to
5647169
Compare
svenwltr
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.