From 04daafdf50febfb3e9b4d5ef87b6ea3f9acf03ce Mon Sep 17 00:00:00 2001 From: Pavel Vanecek Date: Mon, 16 Oct 2023 22:11:38 +0900 Subject: [PATCH] Remove unit test that was comparing new/old reduce-css-calc Why? It's not testing anything - it throws, and the error is not reported as a failing test but instead as a log message in the console. Instead I have replaced it with a `.not.toThrow()` call which at least tests that our new implementation is correct. The old one throws so I removed it completely. --- package-lock.json | 47 ------------------------ package.json | 1 - test/util/ReduceCssCalcPrototype.spec.ts | 15 +------- types.d.ts | 1 - 4 files changed, 2 insertions(+), 62 deletions(-) diff --git a/package-lock.json b/package-lock.json index a4b5b11fcd..0d1c1e7f7b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -89,7 +89,6 @@ "react-dom": "^16.14.0", "react-router-dom": "^5.1.2", "reassure": "^0.9.1", - "reduce-css-calc": "^2.1.8", "rimraf": "^3.0.2", "storybook": "^7.4.6", "storybook-addon-performance": "^0.17.1", @@ -17143,12 +17142,6 @@ "url": "https://github.com/sponsors/fb55" } }, - "node_modules/css-unit-converter": { - "version": "1.1.2", - "resolved": "https://registry.npmjs.org/css-unit-converter/-/css-unit-converter-1.1.2.tgz", - "integrity": "sha512-IiJwMC8rdZE0+xiEZHeru6YoONC4rfPMqGm2W85jMIbkFvv5nFTwJVFHam2eFrN6txmoUYFAFXiv8ICVeTO0MA==", - "dev": true - }, "node_modules/css-what": { "version": "6.1.0", "resolved": "https://registry.npmjs.org/css-what/-/css-what-6.1.0.tgz", @@ -30483,22 +30476,6 @@ "node": ">=8" } }, - "node_modules/reduce-css-calc": { - "version": "2.1.8", - "resolved": "https://registry.npmjs.org/reduce-css-calc/-/reduce-css-calc-2.1.8.tgz", - "integrity": "sha512-8liAVezDmUcH+tdzoEGrhfbGcP7nOV4NkGE3a74+qqvE7nt9i4sKLGBuZNOnpI4WiGksiNPklZxva80061QiPg==", - "dev": true, - "dependencies": { - "css-unit-converter": "^1.1.1", - "postcss-value-parser": "^3.3.0" - } - }, - "node_modules/reduce-css-calc/node_modules/postcss-value-parser": { - "version": "3.3.1", - "resolved": "https://registry.npmjs.org/postcss-value-parser/-/postcss-value-parser-3.3.1.tgz", - "integrity": "sha512-pISE66AbVkp4fDQ7VHBwRNXzAAKJjw4Vw7nWI/+Q3vuly7SNfgYXvm6i5IgFylHGK5sP/xHAbB7N49OS4gWNyQ==", - "dev": true - }, "node_modules/refractor": { "version": "3.6.0", "resolved": "https://registry.npmjs.org/refractor/-/refractor-3.6.0.tgz", @@ -47431,12 +47408,6 @@ "nth-check": "^2.0.1" } }, - "css-unit-converter": { - "version": "1.1.2", - "resolved": "https://registry.npmjs.org/css-unit-converter/-/css-unit-converter-1.1.2.tgz", - "integrity": "sha512-IiJwMC8rdZE0+xiEZHeru6YoONC4rfPMqGm2W85jMIbkFvv5nFTwJVFHam2eFrN6txmoUYFAFXiv8ICVeTO0MA==", - "dev": true - }, "css-what": { "version": "6.1.0", "resolved": "https://registry.npmjs.org/css-what/-/css-what-6.1.0.tgz", @@ -57365,24 +57336,6 @@ "strip-indent": "^3.0.0" } }, - "reduce-css-calc": { - "version": "2.1.8", - "resolved": "https://registry.npmjs.org/reduce-css-calc/-/reduce-css-calc-2.1.8.tgz", - "integrity": "sha512-8liAVezDmUcH+tdzoEGrhfbGcP7nOV4NkGE3a74+qqvE7nt9i4sKLGBuZNOnpI4WiGksiNPklZxva80061QiPg==", - "dev": true, - "requires": { - "css-unit-converter": "^1.1.1", - "postcss-value-parser": "^3.3.0" - }, - "dependencies": { - "postcss-value-parser": { - "version": "3.3.1", - "resolved": "https://registry.npmjs.org/postcss-value-parser/-/postcss-value-parser-3.3.1.tgz", - "integrity": "sha512-pISE66AbVkp4fDQ7VHBwRNXzAAKJjw4Vw7nWI/+Q3vuly7SNfgYXvm6i5IgFylHGK5sP/xHAbB7N49OS4gWNyQ==", - "dev": true - } - } - }, "refractor": { "version": "3.6.0", "resolved": "https://registry.npmjs.org/refractor/-/refractor-3.6.0.tgz", diff --git a/package.json b/package.json index 92bb986f82..3297a79591 100644 --- a/package.json +++ b/package.json @@ -146,7 +146,6 @@ "react-dom": "^16.14.0", "react-router-dom": "^5.1.2", "reassure": "^0.9.1", - "reduce-css-calc": "^2.1.8", "rimraf": "^3.0.2", "storybook": "^7.4.6", "storybook-addon-performance": "^0.17.1", diff --git a/test/util/ReduceCssCalcPrototype.spec.ts b/test/util/ReduceCssCalcPrototype.spec.ts index 29587f3be6..c5bafa3157 100644 --- a/test/util/ReduceCssCalcPrototype.spec.ts +++ b/test/util/ReduceCssCalcPrototype.spec.ts @@ -1,5 +1,3 @@ -import oldReduceCSSCalc from 'reduce-css-calc'; -import { log } from 'console'; import { reduceCSSCalc, safeEvaluateExpression } from '../../src/util/ReduceCSSCalc'; describe('number calculate', () => { @@ -84,7 +82,7 @@ const cssLengthPair = cssLengthUnits.reduce((result, unit1, index1) return result; }, []); -describe('reduce-css-calc', () => { +describe('reduceCSSCalc', () => { cssLengthPair.forEach(([unit1, unit2]) => { [ { capHeight: `123${unit1}`, lineHeight: `456${unit2}`, wordsByLines: 3 }, @@ -101,16 +99,7 @@ describe('reduce-css-calc', () => { `calc(${capHeight} * -${lineHeight})`, `calc(${capHeight} / -${lineHeight})`, ].forEach(calcString => { - try { - const newCalc = reduceCSSCalc(calcString); - const prevCalc = oldReduceCSSCalc(calcString); - - if (!(prevCalc.includes('calc') || prevCalc.includes(' '))) { - expect(prevCalc).toEqual(newCalc); - } - } catch (e) { - log('prevCalc throw error'); - } + expect(() => reduceCSSCalc(calcString)).not.toThrow(); }); }); }); diff --git a/types.d.ts b/types.d.ts index 6d14be937d..29367ecf37 100644 --- a/types.d.ts +++ b/types.d.ts @@ -1,3 +1,2 @@ declare module 'recharts-scale'; declare module 'react-smooth'; -declare module 'reduce-css-calc';