New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SVN support #156

Merged
merged 6 commits into from Sep 19, 2016

Conversation

Projects
None yet
3 participants
@DavidS48
Contributor

DavidS48 commented Sep 19, 2016

Added support for version control with SVN (partially fixes #88)

New code added to record repository URI, commit number and local diffs and to display them in the CLI and the GUI.

Added a dependency on PySVN, although the currently released version of this doesn't support local diffs, so I had to hack that in manually with subprocess...

@robintw

This comment has been minimized.

Show comment
Hide comment
@robintw

robintw Sep 19, 2016

Contributor

@jvdzwaan: This is a PR from one of the new guys sprinting with me at PyConUK 2016. Very sensibly, he's added some extra examples to the GUI tests - but neither he nor I are sure how to run them.

Can you see whether what he has added makes sense? And tell us how to run them?

Contributor

robintw commented Sep 19, 2016

@jvdzwaan: This is a PR from one of the new guys sprinting with me at PyConUK 2016. Very sensibly, he's added some extra examples to the GUI tests - but neither he nor I are sure how to run them.

Can you see whether what he has added makes sense? And tell us how to run them?

@jvdzwaan

This comment has been minimized.

Show comment
Hide comment
@jvdzwaan

jvdzwaan Sep 19, 2016

Contributor

pip install nosetests and to run the tests just nosetests.

After a very quick look, the changes and tests seem to make sense. To be honest, I'm not sure all existing tests still work...

Contributor

jvdzwaan commented Sep 19, 2016

pip install nosetests and to run the tests just nosetests.

After a very quick look, the changes and tests seem to make sense. To be honest, I'm not sure all existing tests still work...

@robintw

This comment has been minimized.

Show comment
Hide comment
@robintw

robintw Sep 19, 2016

Contributor

You're right - it seems like lots of tests that are there already currently fail anyway. Oh well, I'll merge this, and we can deal with testing with the SSI once they've done the basics.

Contributor

robintw commented Sep 19, 2016

You're right - it seems like lots of tests that are there already currently fail anyway. Oh well, I'll merge this, and we can deal with testing with the SSI once they've done the basics.

@robintw robintw merged commit ff440db into recipy:master Sep 19, 2016

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment