New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy #213

Merged
merged 3 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@oew1v07

oew1v07 commented Nov 5, 2018

This adds the np.load function as an input, this will need to be merged prior to #207 as it depends on it being fixed.

@@ -62,6 +62,10 @@ def genfromtxt(self):
np.genfromtxt(file_name, delimiter=",",
missing_values="", filling_values=-1)
def load(self):

This comment has been minimized.

@robintw

robintw Nov 5, 2018

Contributor

Could you add a very brief docstring here? (Like the other functions in this module)

@robintw

This comment has been minimized.

Contributor

robintw commented Nov 5, 2018

Looks great - thank you. I've just added one simple comment on a docstring I'd like you to add.

I see Travis has passed, I'll just wait for AppVeyor to pass too, and then merge this.

(Once this is merged, just pull from master in to your other PR and that should work too)

@oew1v07

This comment has been minimized.

oew1v07 commented Nov 5, 2018

Right added that doc string. Just waiting for travis and appveyor.

@robintw

This comment has been minimized.

Contributor

robintw commented Nov 5, 2018

This is passing for all except 3.5 on AppVeyor, and that seems to be because it timed out due to some weird conda download slowdowns. Merging anyway, as it's only a small change.

@robintw robintw merged commit 3bd7bac into recipy:master Nov 5, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment