feat(viz): close the Review approval-queue loop end-to-end#41
Merged
NagyVikt merged 1 commit intoMay 14, 2026
Merged
Conversation
Adds the real event source for the Review tab and wires both review daemons into the fleet bringup, so the Review screen now reflects live Codex auto-reviewer activity instead of the demo fixture. * `scripts/codex-fleet/review-pane-scanner.sh` — walks the codex-fleet worker panes via `tmux capture-pane`, detects the Codex auto-reviewer block (`⚠ Automatic approval review …` + `(risk: …, authorization: …)` + optional `✓ Request approved for …`), and emits matching events through `review-queue.sh`. Stable `REV-<sha1[0:6]>` ids keyed on (agent, normalized payload) dedupe across ticks; supports `--once`, `--dry-run`, and `--fixture FILE` for testing without a live tmux session. * `scripts/codex-fleet/full-bringup.sh` — adds `review-queue` and `review-scanner` ticker windows next to the existing fleet-tick / cap-swap / state-pump / review-detector daemons; prefers `review-anim.sh` over the legacy `review-board.sh` for the review tab. * `scripts/codex-fleet/review-queue.sh` — fixes a producer bug surfaced by the scanner: `emit-pending --pane` previously used `--argjson` and exploded on non-numeric tmux pane ids (`%5`, fixture names). Pane is now serialized as a JSON string (or null when absent); the renderer is unchanged because `jq -r '.pane // ""'` consumes either shape. Test (`scripts/codex-fleet/test/test-review-pane-scanner.sh`) covers approved / denied / pending blocks, dedup across repeated scans, quiet panes emitting nothing, and `--dry-run` not mutating the event log. All three review suites (anim + queue + scanner) PASS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NagyVikt
deleted the
agent/claude/review-pane-scanner-daemon-bringup-2026-05-14-23-06
branch
3 tasks
NagyVikt
added a commit
that referenced
this pull request
May 20, 2026
…t sweep) (#199) Audited docs/future/PROTOCOL.md against the actual repo + git history and flipped 20 stale `state: PROPOSED` lines to `state: SHIPPED` for items whose implementation has clearly landed on main. Each item's acceptance verification command runs green and the touched script/file already implements the proposal. Updates (section → slug → representative PR): - 1.4.1 Formal lifecycle states for every improvement entry → PR #171 (scripts/protocol/{protocol-state,check-states}.sh + state lines) - 7.4.1 --help/--version on stall-watcher.sh → PR #1 - 9.4.1 --help/--version on plan-watcher.sh → PR #46 - 10.4.1 --help/--version on review-queue.sh → PR #37 - 11.4.1 --help/--version on review-pane-scanner.sh → PR #41 - 12.4.1 --help/--version on auto-reviewer.sh → PR #99 - 17.4.1 --help/--version on show-fleet.sh → PR #139 - 18.4.1 --help/--version on token-meter.sh → PR #17 - 19.4.1 --help/--version on warm-pool.sh → PR #1 - 20.4.1 --help/--version on spawn-fleet.sh → PR #1 - 21.4.1 --help/--version on dispatch-plan.sh → PR #133 - 23.4.1 --help/--version on proactive-probe.sh → PR #1 - 24.4.1 --help/--version on claim-trigger.sh → PR #1 - 27.4.1 --help/--version on claude-supervisor.sh → PR #116 - 33.4.1 --help/--version on plan-tree-pin.sh → PR #1 - 36.4.1 --help/--version on supervisor.sh → PR #1 - 37.4.1 --help/--version on patch-codex-prompts.sh → PR #1 - 39.4.1 --help/--version on down.sh → PR #1 - 41.4.1 --help/--version on add-workers.sh → PR #1 - 42.4.1 --help/--version on codex-fleet-2.sh → PR #1 Diff is exactly 20 `- state: PROPOSED` → `- state: SHIPPED` line edits in docs/future/PROTOCOL.md; nothing else touched. Both governance checks still pass: bash scripts/protocol/check-states.sh # exit 0 bash scripts/protocol/protocol-state.sh --summary # SHIPPED: 0 → 20 PR refs live in this commit body / PR description rather than inline in the state line, because both check-states.sh and protocol-state.sh require the state token to be the bare enum value (e.g. `SHIPPED`); any suffix breaks both checks. Co-authored-by: NagyVikt <nagy.viktordp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by gx branch finish (PR flow).