New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry of #102 #111

Merged
merged 2 commits into from Aug 1, 2018

Conversation

Projects
None yet
3 participants
@kt3k
Copy link
Collaborator

kt3k commented Aug 1, 2018

  • greenkeeper-lockfile-update が機能するためには、そのブランチの最初のビルドかつ、最初のジョブである必要がある *1 ため、build ジョブを削除して、install で checkout と greenkeeper-lockfile-update を実行するように修正しました
  • ドキュメントによると greenkeeper-lockfile-upload は CI としてのチェックが終わった後に実行されるべきなようなので、upload_lock ジョブは各種チェックを require するように変更しました。
  • greenkeeper-lockfile-update の中でなぜか git config user.name ... などの設定が効かず、コミットが失敗する現象が起きていたため、install ジョブに git user 指定用の環境変数を追加しました。

greenkeeper[bot] and others added some commits Jul 30, 2018

fix(package): update recompose to version 0.28.0
plus fixing lockfile update scripts

@yosuke-furukawa yosuke-furukawa merged commit de90d37 into master Aug 1, 2018

10 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
ci/circleci: analytics Your tests passed on CircleCI!
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build-asset Your tests passed on CircleCI!
Details
ci/circleci: build-storybook Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: upload_lock Your tests passed on CircleCI!
Details

@kt3k kt3k deleted the greenkeeper/recompose-0.28.0-retry-9 branch Aug 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment