From 037cfd435d69ea43dff9e44c17e252fdf40fa09a Mon Sep 17 00:00:00 2001 From: TomasVotruba Date: Sat, 15 May 2021 12:07:38 +0100 Subject: [PATCH] fix typo in option name that lead to missed config loader --- config/config.php | 5 ----- config/parameters.php | 2 ++ rector.php | 1 + src/Bootstrap/RectorConfigsResolver.php | 2 +- src/HttpKernel/RectorKernel.php | 1 - 5 files changed, 4 insertions(+), 7 deletions(-) diff --git a/config/config.php b/config/config.php index e60c55f3578..63a152a3004 100644 --- a/config/config.php +++ b/config/config.php @@ -3,7 +3,6 @@ declare(strict_types=1); use Rector\Core\Bootstrap\ExtensionConfigResolver; -use Rector\Core\Configuration\Option; use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator; return static function (ContainerConfigurator $containerConfigurator): void { @@ -20,8 +19,4 @@ // require only in dev $containerConfigurator->import(__DIR__ . '/../utils/compiler/config/config.php', null, 'not_found'); - - // to override extension-loaded config - $parameters = $containerConfigurator->parameters(); - $parameters->set(Option::PHPSTAN_FOR_RECTOR_PATH, getcwd() . '/phpstan-for-rector.neon'); }; diff --git a/config/parameters.php b/config/parameters.php index 7c3fdc75163..f170aa7410b 100644 --- a/config/parameters.php +++ b/config/parameters.php @@ -27,6 +27,8 @@ $parameters->set(Option::NESTED_CHAIN_METHOD_CALL_LIMIT, 30); $parameters->set(Option::SKIP, []); + $parameters->set(Option::PHPSTAN_FOR_RECTOR_PATH, null); + // cache $parameters->set(Option::ENABLE_CACHE, false); $parameters->set(Option::CACHE_DIR, sys_get_temp_dir() . '/rector_cached_files'); diff --git a/rector.php b/rector.php index a84e9fba5e5..99894d8c14e 100644 --- a/rector.php +++ b/rector.php @@ -104,6 +104,7 @@ '*/Expected*/*', ]); + $parameters->set(Option::PHPSTAN_FOR_RECTOR_PATH, __DIR__ . '/phpstan-for-rector.neon'); $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_74); $parameters->set(Option::ENABLE_CACHE, true); }; diff --git a/src/Bootstrap/RectorConfigsResolver.php b/src/Bootstrap/RectorConfigsResolver.php index 8fb23c4ef67..7db67243536 100644 --- a/src/Bootstrap/RectorConfigsResolver.php +++ b/src/Bootstrap/RectorConfigsResolver.php @@ -43,7 +43,7 @@ private function resolveRectorRecipeConfig(ArgvInput $argvInput): ?SmartFileInfo private function resolveFromInput(ArgvInput $argvInput): ?SmartFileInfo { - $configValue = $this->getOptionValue($argvInput, ['config', 'c']); + $configValue = $this->getOptionValue($argvInput, ['--config', '-c']); if ($configValue === null) { return null; } diff --git a/src/HttpKernel/RectorKernel.php b/src/HttpKernel/RectorKernel.php index b80efe6c2ee..5acadf5268f 100644 --- a/src/HttpKernel/RectorKernel.php +++ b/src/HttpKernel/RectorKernel.php @@ -69,7 +69,6 @@ public function getLogDir(): string public function registerContainerConfiguration(LoaderInterface $loader): void { $loader->load(__DIR__ . '/../../config/config.php'); - foreach ($this->configFileInfos as $configFileInfo) { $loader->load($configFileInfo->getRealPath()); }