From 1e085a0c5a47243c624c46ff7397a80bf983f776 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 1 May 2023 20:47:27 +0700 Subject: [PATCH] [CodeQuality] Improve SimplifyIfElseToTernaryRector performance (#3721) --- .../CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rules/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php b/rules/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php index d29ec8d00a3..f3dabd208ee 100644 --- a/rules/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php +++ b/rules/CodeQuality/Rector/If_/SimplifyIfElseToTernaryRector.php @@ -181,8 +181,8 @@ private function resolveOnlyStmtAssignExpr(array $stmts): ?Expr private function haveNestedTernary(array $nodes): bool { foreach ($nodes as $node) { - $betterNodeFinderFindInstanceOf = $this->betterNodeFinder->findInstanceOf($node, Ternary::class); - if ($betterNodeFinderFindInstanceOf !== []) { + $ternary = $this->betterNodeFinder->findFirstInstanceOf($node, Ternary::class); + if ($ternary instanceof Ternary) { return true; } }