From 23e3da2d6eee90e4f2a31c31062aabaeba77ba69 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 15 Mar 2024 03:14:23 +0700 Subject: [PATCH] [CodeQuality] Remove BoolvalToTypeCastRector and FloatvalToTypeCastRector as well from code-quality set (#5722) --- config/set/code-quality.php | 4 ---- utils/Command/MissingInSetCommand.php | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/config/set/code-quality.php b/config/set/code-quality.php index 1621bc042a1..086311b8de8 100644 --- a/config/set/code-quality.php +++ b/config/set/code-quality.php @@ -27,11 +27,9 @@ use Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector; use Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector; use Rector\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector; -use Rector\CodeQuality\Rector\FuncCall\BoolvalToTypeCastRector; use Rector\CodeQuality\Rector\FuncCall\CallUserFuncWithArrowFunctionToInlineRector; use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector; use Rector\CodeQuality\Rector\FuncCall\CompactToVariablesRector; -use Rector\CodeQuality\Rector\FuncCall\FloatvalToTypeCastRector; use Rector\CodeQuality\Rector\FuncCall\InlineIsAInstanceOfRector; use Rector\CodeQuality\Rector\FuncCall\IsAWithStringWithThirdArgumentRector; use Rector\CodeQuality\Rector\FuncCall\RemoveSoleValueSprintfRector; @@ -140,7 +138,6 @@ SimplifyBoolIdenticalTrueRector::class, SimplifyRegexPatternRector::class, BooleanNotIdenticalToNotIdenticalRector::class, - FloatvalToTypeCastRector::class, CallableThisArrayToAnonymousFunctionRector::class, AndAssignsToSeparateLinesRector::class, CompactToVariablesRector::class, @@ -151,7 +148,6 @@ RemoveSoleValueSprintfRector::class, ShortenElseIfRector::class, ArrayMergeOfNonArraysToSimpleArrayRector::class, - BoolvalToTypeCastRector::class, ArrayKeyExistsTernaryThenValueToCoalescingRector::class, AbsolutizeRequireAndIncludePathRector::class, ChangeArrayPushToArrayAssignRector::class, diff --git a/utils/Command/MissingInSetCommand.php b/utils/Command/MissingInSetCommand.php index 7aa571df297..778c992ec49 100644 --- a/utils/Command/MissingInSetCommand.php +++ b/utils/Command/MissingInSetCommand.php @@ -5,6 +5,8 @@ namespace Rector\Utils\Command; use Nette\Utils\Strings; +use Rector\CodeQuality\Rector\FuncCall\BoolvalToTypeCastRector; +use Rector\CodeQuality\Rector\FuncCall\FloatvalToTypeCastRector; use Rector\CodeQuality\Rector\FuncCall\IntvalToTypeCastRector; use Rector\CodeQuality\Rector\FuncCall\StrvalToTypeCastRector; use Rector\CodingStyle\Rector\FuncCall\ArraySpreadInsteadOfArrayMergeRector; @@ -38,6 +40,8 @@ final class MissingInSetCommand extends Command WhileNullableToInstanceofRector::class, IntvalToTypeCastRector::class, StrvalToTypeCastRector::class, + BoolvalToTypeCastRector::class, + FloatvalToTypeCastRector::class, // changes behavior, should be applied on purpose regardless PHP 7.3 level JsonThrowOnErrorRector::class, // in confront with sub type safe belt detection on RemoveUseless*TagRector