From 3ef3e35c45970bce4000f45f9c1cb651f078c5a0 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Sat, 24 Feb 2024 02:26:27 +0700
Subject: [PATCH] [Php71] Skip re-assign as string on AssignArrayToStringRector
 part 2 (#5661)

* [Php71] Skip re-assign as string on AssignArrayToStringRector part 2

* fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>
---
 .../Fixture/skip_reassigned_as_string2.php.inc    | 15 +++++++++++++++
 .../Rector/Assign/AssignArrayToStringRector.php   |  8 +++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string2.php.inc

diff --git a/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string2.php.inc b/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string2.php.inc
new file mode 100644
index 00000000000..57632a3e3df
--- /dev/null
+++ b/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string2.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+// not inside function with direct check on purpose
+
+if ($cdate) {
+    $where[] = 'n.sometable <= 1000';
+}
+
+if (empty($where)) {
+    $where = '';
+} else {
+    $where = 'WHERE ' . implode(' AND ', $where);
+}
+
+$sql = 'SELECT something, something FROM table1' . $where;
\ No newline at end of file
diff --git a/rules/Php71/Rector/Assign/AssignArrayToStringRector.php b/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
index e2256531546..3e5ad023527 100644
--- a/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
+++ b/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
@@ -4,6 +4,7 @@
 
 namespace Rector\Php71\Rector\Assign;
 
+use PHPStan\Type\UnionType;
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
@@ -245,7 +246,12 @@ private function refactorAssign(
             return null;
         }
 
-        if ($this->nodeTypeResolver->getNativeType($assign->var)->isArray()->yes()) {
+        $type = $this->nodeTypeResolver->getNativeType($assign->var);
+        if ($type->isArray()->yes()) {
+            return null;
+        }
+
+        if ($type instanceof UnionType) {
             return null;
         }