From 4e3be87945bf57a1f4c7aaf51696c55ae7617054 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sun, 6 Aug 2023 16:50:39 +0700 Subject: [PATCH] [TypeDeclaration][CodeQuality] Move ReturnTypeFromStrictScalarReturnExprRector from CodeQuality to TypeDeclaration set (#4668) --- config/set/code-quality.php | 2 -- config/set/type-declaration.php | 2 +- .../conditional_type_for_parameter.php.inc | 4 ++-- .../Fixture/final_method.php.inc | 4 ++-- .../Fixture/return_concat.php.inc | 4 ++-- .../Fixture/return_concat_all_int.php.inc | 4 ++-- .../Fixture/return_concat_multiple.php.inc | 4 ++-- .../Fixture/return_is_array.php.inc | 4 ++-- .../Fixture/return_scalar_cast.php.inc | 4 ++-- .../Fixture/skip_custom_function.php.inc | 2 +- .../Fixture/skip_empty_return.php.inc | 2 +- .../Fixture/skip_if_child_has_typed.php.inc | 2 +- .../Fixture/skip_mixed.php.inc | 2 +- .../Fixture/skip_multi_return.php.inc | 15 +++++++++++++++ .../Fixture/some_class.php.inc | 4 ++-- .../Fixture/string_append_variable.php.inc | 4 ++-- .../Fixture/string_from_encapsed.php.inc | 4 ++-- .../Fixture/string_herenowdoc.php.inc | 4 ++-- .../Fixture/with_join_args.php.inc | 4 ++-- .../Fixture/with_return_function_strict.php.inc | 4 ++-- ...rnTypeFromStrictScalarReturnExprRectorTest.php | 2 +- .../config/configured_rule.php | 2 +- .../Fixture/multi_scalar.php.inc} | 8 ++++---- ...ReturnTypeFromStrictScalarReturnExprRector.php | 9 +++++++-- 24 files changed, 59 insertions(+), 41 deletions(-) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc (67%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/final_method.php.inc (70%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/return_concat.php.inc (52%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/return_concat_all_int.php.inc (50%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/return_concat_multiple.php.inc (60%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/return_is_array.php.inc (56%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/return_scalar_cast.php.inc (53%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/skip_custom_function.php.inc (68%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/skip_empty_return.php.inc (61%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/skip_if_child_has_typed.php.inc (68%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/skip_mixed.php.inc (57%) create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/skip_multi_return.php.inc rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/some_class.php.inc (60%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/string_append_variable.php.inc (67%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/string_from_encapsed.php.inc (57%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/string_herenowdoc.php.inc (55%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/with_join_args.php.inc (63%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/with_return_function_strict.php.inc (55%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/ReturnTypeFromStrictScalarReturnExprRectorTest.php (86%) rename rules-tests/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/config/configured_rule.php (69%) rename rules-tests/{CodeQuality/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/multi_return.php.inc => TypeDeclaration/Rector/ClassMethod/ReturnUnionTypeRector/Fixture/multi_scalar.php.inc} (56%) rename rules/{CodeQuality => TypeDeclaration}/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector.php (90%) diff --git a/config/set/code-quality.php b/config/set/code-quality.php index 954a3a7c58d..81cf60aca83 100644 --- a/config/set/code-quality.php +++ b/config/set/code-quality.php @@ -14,7 +14,6 @@ use Rector\CodeQuality\Rector\ClassMethod\InlineArrayReturnAssignRector; use Rector\CodeQuality\Rector\ClassMethod\LocallyCalledStaticMethodToNonStaticRector; use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector; -use Rector\CodeQuality\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector; use Rector\CodeQuality\Rector\Concat\JoinStringConcatRector; use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector; use Rector\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector; @@ -179,7 +178,6 @@ InlineIsAInstanceOfRector::class, TernaryFalseExpressionToIfRector::class, InlineConstructorDefaultToPropertyRector::class, - ReturnTypeFromStrictScalarReturnExprRector::class, TernaryEmptyArrayArrayDimFetchToCoalesceRector::class, OptionalParametersAfterRequiredRector::class, SimplifyEmptyCheckOnEmptyArrayRector::class, diff --git a/config/set/type-declaration.php b/config/set/type-declaration.php index 3e608d573ad..62fa5b350c2 100644 --- a/config/set/type-declaration.php +++ b/config/set/type-declaration.php @@ -2,7 +2,6 @@ declare(strict_types=1); -use Rector\CodeQuality\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector; use Rector\Config\RectorConfig; use Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector; use Rector\TypeDeclaration\Rector\Class_\PropertyTypeFromStrictSetterGetterRector; @@ -26,6 +25,7 @@ use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictParamRector; +use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictScalarReturnExprRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector; use Rector\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector; diff --git a/rules-tests/CodeQuality/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc similarity index 67% rename from rules-tests/CodeQuality/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc rename to rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc index 83ee1887411..d650017c948 100644 --- a/rules-tests/CodeQuality/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc +++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictScalarReturnExprRector/Fixture/conditional_type_for_parameter.php.inc @@ -1,6 +1,6 @@ returnType = $returnTypeNode; return $node; }