From 522668e4edce544bcb17ba3d71182629df19fd95 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 20 Feb 2024 22:59:11 +0700 Subject: [PATCH] [Performance] [VendorLocker] Early allow change return type on private method on ClassMethodReturnTypeOverrideGuard::shouldSkipClassMethod() (#5642) --- .../NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php b/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php index dc9792c1983..7b56e3895e9 100644 --- a/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php +++ b/src/VendorLocker/NodeVendorLocker/ClassMethodReturnTypeOverrideGuard.php @@ -32,6 +32,11 @@ public function shouldSkipClassMethod(ClassMethod $classMethod, Scope $scope): b return true; } + // early allow add return type on private method + if ($classMethod->isPrivate()) { + return false; + } + $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod); if (! $classReflection instanceof ClassReflection) { return true;