From 7cdd03ed7733e2d8d12d68e5750a89b7f0dda829 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Tue, 14 Dec 2021 15:22:38 +0100
Subject: [PATCH] [PHP 8.1] Fix IntersectionTypesRector for non-object types
 (#1495)

---
 .../Fixture/skip_scalar_types.php.inc         | 13 ++++++++++++
 .../Fixture/some_class.php.inc                | 16 +++++++++-----
 .../Source/FirstObjectToIntersect.php         | 10 +++++++++
 .../Source/SecondObjectToIntersect.php        | 10 +++++++++
 .../FunctionLike/IntersectionTypesRector.php  | 21 +++++++++++++++++++
 5 files changed, 65 insertions(+), 5 deletions(-)
 create mode 100644 rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/skip_scalar_types.php.inc
 create mode 100644 rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/FirstObjectToIntersect.php
 create mode 100644 rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/SecondObjectToIntersect.php

diff --git a/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/skip_scalar_types.php.inc b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/skip_scalar_types.php.inc
new file mode 100644
index 00000000000..0f82e7f6f15
--- /dev/null
+++ b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/skip_scalar_types.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Fixture;
+
+final class SkipScalarType
+{
+    /**
+     * @param string&int $types
+     */
+    public function process($types)
+    {
+    }
+}
diff --git a/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/some_class.php.inc b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/some_class.php.inc
index d95bde2f77e..785cbf44e98 100644
--- a/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/some_class.php.inc
+++ b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Fixture/some_class.php.inc
@@ -2,10 +2,13 @@
 
 namespace Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Fixture;
 
-final class SomeClass
+use Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\FirstObjectToIntersect;
+use Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\SecondObjectToIntersect;
+
+final class SkipScalarTypes
 {
     /**
-     * @param string&int $types
+     * @param FirstObjectToIntersect&SecondObjectToIntersect $types
      */
     public function process($types)
     {
@@ -18,12 +21,15 @@ final class SomeClass
 
 namespace Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Fixture;
 
-final class SomeClass
+use Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\FirstObjectToIntersect;
+use Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\SecondObjectToIntersect;
+
+final class SkipScalarTypes
 {
     /**
-     * @param string&int $types
+     * @param FirstObjectToIntersect&SecondObjectToIntersect $types
      */
-    public function process(int&string $types)
+    public function process(\Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\FirstObjectToIntersect&\Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source\SecondObjectToIntersect $types)
     {
     }
 }
diff --git a/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/FirstObjectToIntersect.php b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/FirstObjectToIntersect.php
new file mode 100644
index 00000000000..13cf2f19d68
--- /dev/null
+++ b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/FirstObjectToIntersect.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source;
+
+final class FirstObjectToIntersect
+{
+
+}
diff --git a/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/SecondObjectToIntersect.php b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/SecondObjectToIntersect.php
new file mode 100644
index 00000000000..6410a8c29f5
--- /dev/null
+++ b/rules-tests/Php81/Rector/FunctionLike/IntersectionTypesRector/Source/SecondObjectToIntersect.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Php81\Rector\FunctionLike\IntersectionTypesRector\Source;
+
+final class SecondObjectToIntersect
+{
+
+}
diff --git a/rules/Php81/Rector/FunctionLike/IntersectionTypesRector.php b/rules/Php81/Rector/FunctionLike/IntersectionTypesRector.php
index 5216bea8ed7..47aa6bef764 100644
--- a/rules/Php81/Rector/FunctionLike/IntersectionTypesRector.php
+++ b/rules/Php81/Rector/FunctionLike/IntersectionTypesRector.php
@@ -10,6 +10,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PHPStan\Type\IntersectionType;
+use PHPStan\Type\TypeWithClassName;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
@@ -110,6 +111,10 @@ private function refactorParamTypes(
                 continue;
             }
 
+            if (! $this->isIntersectionableType($paramType)) {
+                continue;
+            }
+
             $phpParserIntersectionType = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode(
                 $paramType,
                 TypeKind::PARAM()
@@ -123,4 +128,20 @@ private function refactorParamTypes(
             $this->hasChanged = true;
         }
     }
+
+    /**
+     * Only class-type are supported https://wiki.php.net/rfc/pure-intersection-types#supported_types
+     */
+    private function isIntersectionableType(IntersectionType $intersectionType): bool
+    {
+        foreach ($intersectionType->getTypes() as $intersectionedType) {
+            if ($intersectionedType instanceof TypeWithClassName) {
+                continue;
+            }
+
+            return false;
+        }
+
+        return true;
+    }
 }