From 89d2c9c4eb2bfddc226136899b1fdb0a99d19a8a Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sun, 17 Dec 2023 13:34:46 +0700 Subject: [PATCH] [Php72] Remove usage on PrivatesAccessor on AnonymousFunctionFactory (#5367) --- rules/Php72/NodeFactory/AnonymousFunctionFactory.php | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/rules/Php72/NodeFactory/AnonymousFunctionFactory.php b/rules/Php72/NodeFactory/AnonymousFunctionFactory.php index f917d85fdc0..4f9d92ce941 100644 --- a/rules/Php72/NodeFactory/AnonymousFunctionFactory.php +++ b/rules/Php72/NodeFactory/AnonymousFunctionFactory.php @@ -39,13 +39,11 @@ use Rector\Core\PhpParser\Node\NodeFactory; use Rector\Core\PhpParser\Parser\InlineCodeParser; use Rector\Core\PhpParser\Parser\SimplePhpParser; -use Rector\Core\Util\Reflection\PrivatesAccessor; use Rector\NodeNameResolver\NodeNameResolver; use Rector\NodeTypeResolver\Node\AttributeKey; use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser; use Rector\PHPStanStaticTypeMapper\Enum\TypeKind; use Rector\StaticTypeMapper\StaticTypeMapper; -use ReflectionParameter; final class AnonymousFunctionFactory { @@ -63,7 +61,6 @@ public function __construct( private readonly SimpleCallableNodeTraverser $simpleCallableNodeTraverser, private readonly SimplePhpParser $simplePhpParser, private readonly AstResolver $astResolver, - private readonly PrivatesAccessor $privatesAccessor, private readonly InlineCodeParser $inlineCodeParser ) { } @@ -260,7 +257,7 @@ private function createParams(PhpMethodReflection $phpMethodReflection, array $p $variable = new Variable($parameterReflection->getName()); $defaultExpr = $this->resolveParamDefaultExpr($parameterReflection, $key, $classMethod); $type = $this->resolveParamType($parameterReflection); - $byRef = $this->isParamByReference($parameterReflection); + $byRef = $parameterReflection->passedByReference()->yes(); $params[] = new Param($variable, $defaultExpr, $type, $byRef); } @@ -280,13 +277,6 @@ private function resolveParamType(ParameterReflection $parameterReflection): Nam ); } - private function isParamByReference(ParameterReflection $parameterReflection): bool - { - /** @var ReflectionParameter $reflection */ - $reflection = $this->privatesAccessor->getPrivateProperty($parameterReflection, 'reflection'); - return $reflection->isPassedByReference(); - } - private function resolveParamDefaultExpr( ParameterReflection $parameterReflection, int $key,