From b92e3788e665f9a260ca8d74fde6e8c574d17456 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Sat, 10 Jun 2023 10:14:01 +0700
Subject: [PATCH] [Php56] Skip variable variable on
 AddDefaultValueForUndefinedVariableRector (#4148)

* [Php56] Skip variable variable on AddDefaultValueForUndefinedVariableRector

* Fixed :tada:

* comment
---
 .../Fixture/skip_variable_variable.php.inc          | 13 +++++++++++++
 .../NodeAnalyzer/UndefinedVariableResolver.php      | 10 +++++-----
 2 files changed, 18 insertions(+), 5 deletions(-)
 create mode 100644 rules-tests/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc

diff --git a/rules-tests/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc b/rules-tests/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc
new file mode 100644
index 00000000000..4b6ec650d3b
--- /dev/null
+++ b/rules-tests/Php56/Rector/FunctionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector\Fixture;
+
+class SkipVariableVariable
+{
+    public function run($abcdef = 'foo')
+    {
+        $$abcdef = 'test';
+
+        return $foo;
+    }
+}
diff --git a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
index 9000297ba6b..ef4e5139e5a 100644
--- a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
+++ b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
@@ -75,6 +75,11 @@ public function resolve(ClassMethod | Function_ | Closure $node): array
                 return null;
             }
 
+            // after variable variable, the variable name got unpredictable, just stop
+            if ($node->name instanceof Variable) {
+                return NodeTraverser::STOP_TRAVERSAL;
+            }
+
             if ($node->getAttribute(AttributeKey::IS_BEING_ASSIGNED) === true) {
                 return null;
             }
@@ -215,11 +220,6 @@ private function shouldSkipVariable(Variable $variable, string $variableName, ar
             return true;
         }
 
-        $checkedVariables = array_filter(
-            $checkedVariables,
-            static fn (string $variableName): bool => $variableName !== ''
-        );
-
         return in_array($variableName, $checkedVariables, true);
     }