Remove ChangeGlobalVariablesToPropertiesRector as the scope might cha…

…nge after the variable is defined, better handle with PHPStan (#4086)
rectorphp · Jun 5, 2023 · be31c8f · be31c8f
1 parent 2dccbb6
commit be31c8f
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 333 deletions.
diff --git a/config/set/privatization.php b/config/set/privatization.php
@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Privatization\Rector\Class_\ChangeGlobalVariablesToPropertiesRector;
 use Rector\Privatization\Rector\Class_\FinalizeClassesWithoutChildrenRector;
 use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector;
 use Rector\Privatization\Rector\MethodCall\PrivatizeLocalGetterToPropertyRector;
@@ -12,7 +11,6 @@
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules([
         FinalizeClassesWithoutChildrenRector::class,
-        ChangeGlobalVariablesToPropertiesRector::class,
         PrivatizeLocalGetterToPropertyRector::class,
         PrivatizeFinalClassPropertyRector::class,
         PrivatizeFinalClassMethodRector::class,

diff --git a/..._/ChangeGlobalVariablesToPropertiesRector/ChangeGlobalVariablesToPropertiesRectorTest.php b/..._/ChangeGlobalVariablesToPropertiesRector/ChangeGlobalVariablesToPropertiesRectorTest.php
diff --git a/...ivatization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/fixture.php.inc b/...ivatization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/fixture.php.inc
diff --git a/...zation/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/global_after.php.inc b/...zation/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/global_after.php.inc
diff --git a/...ctor/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/skip_read_only_global.php.inc b/...ctor/Class_/ChangeGlobalVariablesToPropertiesRector/Fixture/skip_read_only_global.php.inc
diff --git a/...tization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/config/configured_rule.php b/...tization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector/config/configured_rule.php
diff --git a/rules/Privatization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector.php b/rules/Privatization/Rector/Class_/ChangeGlobalVariablesToPropertiesRector.php