From d754bec5f11ce2d37928901c6998e1cc62e6f20d Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Fri, 23 Feb 2024 17:00:56 +0700
Subject: [PATCH]  [Php71] Skip re-assign as string on
 AssignArrayToStringRector  (#5659)

* [Php71] Skip re-assign as string on AssignArrayToStringRector

* fixture

* [ci-review] Rector Rectify

* [Php71] Skip re-assign as string on AssignArrayToStringRector

---------

Co-authored-by: GitHub Action <actions@github.com>
---
 .../Fixture/skip_reassigned_as_string.php.inc | 21 +++++++++++++++++++
 .../Assign/AssignArrayToStringRector.php      |  6 +++++-
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string.php.inc

diff --git a/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string.php.inc b/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string.php.inc
new file mode 100644
index 00000000000..9e4e614608c
--- /dev/null
+++ b/rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string.php.inc
@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\Assign\AssignArrayToStringRector\Fixture;
+
+final class SkipReAssignedAsString
+{
+    public function fun($cdate)
+    {
+        if ($cdate) {
+            $where[] = 'n.sometable <= 1000';
+        }
+
+        if (empty($where)) {
+            $where = '';
+        } else {
+            $where = 'WHERE ' . implode(' AND ', $where);
+        }
+
+        $sql = 'SELECT something, something FROM table1' . $where;
+    }
+}
diff --git a/rules/Php71/Rector/Assign/AssignArrayToStringRector.php b/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
index 6658fa4eeb1..e2256531546 100644
--- a/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
+++ b/rules/Php71/Rector/Assign/AssignArrayToStringRector.php
@@ -237,11 +237,15 @@ private function refactorAssign(
         Assign $assign,
         Namespace_|FileWithoutNamespace|ClassMethod|Function_|Closure $node
     ): ?Assign {
+        if (! $assign->var instanceof Variable) {
+            return null;
+        }
+
         if (! $this->isEmptyString($assign->expr)) {
             return null;
         }
 
-        if (! $assign->var instanceof Variable) {
+        if ($this->nodeTypeResolver->getNativeType($assign->var)->isArray()->yes()) {
             return null;
         }