From f5a45a5aeb6e5e1264d546e55dbd8880046b36ce Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Thu, 22 Feb 2024 21:09:52 +0700 Subject: [PATCH] [BetterPhpDocParser] Clean up unnecessary create new ConstFetchNode() on ArrayItemClassNameDecorator (#5658) --- .../PhpDocParser/ArrayItemClassNameDecorator.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/BetterPhpDocParser/PhpDocParser/ArrayItemClassNameDecorator.php b/src/BetterPhpDocParser/PhpDocParser/ArrayItemClassNameDecorator.php index c2e4f7056cf..3ed45e343c9 100644 --- a/src/BetterPhpDocParser/PhpDocParser/ArrayItemClassNameDecorator.php +++ b/src/BetterPhpDocParser/PhpDocParser/ArrayItemClassNameDecorator.php @@ -6,7 +6,6 @@ use Rector\BetterPhpDocParser\PhpDoc\ArrayItemNode; use PhpParser\Node as PhpNode; -use PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode; use PHPStan\PhpDocParser\Ast\Node; use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode; use Rector\BetterPhpDocParser\Contract\PhpDocParser\PhpDocNodeDecoratorInterface; @@ -49,19 +48,16 @@ public function decorate(PhpDocNode $phpDocNode, PhpNode $phpNode): void return null; } - $firstName = $splitScopeResolution[0]; - $constFetchNode = new ConstFetchNode($firstName, $firstName); - - $className = $this->resolveFullyQualifiedClass($constFetchNode, $phpNode); + $className = $this->resolveFullyQualifiedClass($splitScopeResolution[0], $phpNode); $node->setAttribute(PhpDocAttributeKey::RESOLVED_CLASS, $className); return $node; }); } - private function resolveFullyQualifiedClass(ConstFetchNode $constFetchNode, PhpNode $phpNode): string + private function resolveFullyQualifiedClass(string $className, PhpNode $phpNode): string { $nameScope = $this->nameScopeFactory->createNameScopeFromNodeWithoutTemplateTypes($phpNode); - return $nameScope->resolveStringName($constFetchNode->className); + return $nameScope->resolveStringName($className); } }