[DeadCode] skip Ds\Map::get() on RemoveNullArgOnNullDefaultParamRector (#7665)

samsonasik · web-flow · commit fa54d46a5458 · 2025-11-25T10:12:41.000+01:00
diff --git a/rules-tests/DeadCode/Rector/MethodCall/RemoveNullArgOnNullDefaultParamRector/Fixture/skip_ds_map_get.php.inc b/rules-tests/DeadCode/Rector/MethodCall/RemoveNullArgOnNullDefaultParamRector/Fixture/skip_ds_map_get.php.inc
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\MethodCall\RemoveNullArgOnNullDefaultParamRector\Fixture;
+
+use Ds\Map;
+
+class SkipDsMapGet
+{
+    public function foo(): void {
+        $map = new Map();
+        $value = $map->get('foo', null);
+        if ($value) {
+            //...
+        }
+    }
+}
diff --git a/rules/DeadCode/NodeAnalyzer/CallLikeParamDefaultResolver.php b/rules/DeadCode/NodeAnalyzer/CallLikeParamDefaultResolver.php
@@ -31,6 +31,13 @@ public function resolveNullPositions(MethodCall|StaticCall|New_|FuncCall $callLi
             return [];
         }
 
+        if ($reflection instanceof MethodReflection && $reflection->getName() === 'get') {
+            $classReflection = $reflection->getDeclaringClass();
+            if ($classReflection->getName() === 'Ds\Map') {
+                return [];
+            }
+        }
+
         $nullPositions = [];
 
         $extendedParametersAcceptor = ParametersAcceptorSelector::combineAcceptors($reflection->getVariants());
