From fb8842d7e9dc39067bef5710c360dea1ce7458a1 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 14 Jun 2021 10:08:44 +0700 Subject: [PATCH] [Php80] Test for misplaced , on multiline in AnnotationToAttributeRector (#219) * Add failing test fixture for AnnotationToAttributeRector # Failing Test for AnnotationToAttributeRector Based on https://getrector.org/demo/ed127b6d-1e04-4f6d-9f10-be3b1a7a2068 * Closes #166 * fixture update Co-authored-by: Oskar Stark --- .../Fixture/multiline_2.php.inc | 45 +++++++++++++++++++ .../config/configured_rule.php | 2 + 2 files changed, 47 insertions(+) create mode 100644 rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/multiline_2.php.inc diff --git a/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/multiline_2.php.inc b/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/multiline_2.php.inc new file mode 100644 index 00000000000..990fa87f11e --- /dev/null +++ b/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/multiline_2.php.inc @@ -0,0 +1,45 @@ + + * + * @ORM\OrderBy({ + * "createdAt": "DESC", + * }) + * + * @ORM\OneToMany(targetEntity=Foo::class, mappedBy="user", orphanRemoval=true) + */ + private Collection $foos; +} + +?> +----- + + * + * + */ + #[\Doctrine\ORM\Mapping\OrderBy(['createdAt' => 'DESC'])] + #[\Doctrine\ORM\Mapping\OneToMany(targetEntity: Foo::class, mappedBy: 'user', orphanRemoval: true)] + private Collection $foos; +} + +?> diff --git a/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php b/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php index 29f0296d389..28aafdb4746 100644 --- a/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php +++ b/rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php @@ -22,6 +22,8 @@ new AnnotationToAttribute('Doctrine\ORM\Mapping\Table'), new AnnotationToAttribute('Doctrine\ORM\Mapping\Id'), new AnnotationToAttribute('Doctrine\ORM\Mapping\Column'), + new AnnotationToAttribute('Doctrine\ORM\Mapping\OrderBy'), + new AnnotationToAttribute('Doctrine\ORM\Mapping\OneToMany'), new AnnotationToAttribute('ApiPlatform\Core\Annotation\ApiResource'), ]), ]]);