[TypeDeclaration] Decouple AddParamTypeFromPropertyTypeRector #3109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-split-param-inferer-2
branch
3 times, most recently
from
1a0109c to
e0c1ff7
Compare
samsonasik
reviewed
Nov 27, 2022
rules/TypeDeclaration/Rector/ClassMethod/AddParamTypeFromPropertyTypeRector.php
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
tv-split-param-inferer-2
branch
3 times, most recently
from
6190940 to
47fd42f
Compare
TomasVotruba
force-pushed
the
tv-split-param-inferer-2
branch
from
47fd42f to
9115798
Compare
samsonasik
reviewed
Nov 27, 2022
| &$propertyStaticTypes | ||
| ): ?int { | ||
| if ($node instanceof Class_ || $node instanceof Function_) { | ||
| // skip anonymous class and closures |
Member
There was a problem hiding this comment.
invalid comment, closure is not Function_, as property fetch can live inside closure
Member
Author
There was a problem hiding this comment.
I see. How would you phrase it?
Member
There was a problem hiding this comment.
Skip anonymous classes and inner function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.