Skip to content

Conversation

@samsonasik
Copy link
Member

Since TypedPropertyRector is now deprecated:

$this->symfonyStyle->error(
'The TypedPropertyRector rule is deprecated, as it works with doc block types that are not reliable and adds invalid types'
);
sleep(5);

running LevelSetList::UP_TO_PHP_74 will not get the typed property functionality, this PR add TypedPropertyFromAssignsRector so when there is assign for property fetch, it will set property type.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit 8584570 into main Nov 29, 2022
@TomasVotruba TomasVotruba deleted the register-typed-property-from-assign branch November 29, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants