[config] Deprecate and remove @noRector annotation, as not reliable DX choice; use skip() method instead#3148
Merged
TomasVotruba merged 4 commits intomainfrom Dec 3, 2022
Merged
Conversation
…t and hard to fit on exact line; use skip() method instead
889abc2 to
3a85387
Compare
1de5e97 to
ffd1ea1
Compare
1707700 to
3bc7082
Compare
3bc7082 to
1a23abe
Compare
This was referenced Dec 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option was useful in the past, when Rector came with unreliable solutions and unknown types.
This was mostly caused by type-guessing from docblock in type declaration set. These rules are now removed, and are replaced by rules that work with reliable and safe strict types: https://twitter.com/rectorphp/status/1599001416718163968
Saying that, these should no be ingnored anymore and fixed the the rule instead.
If you still need to ignore some other rule for non-fixable reason, use skip() method instead, to keep it visible 👍
Currently, the Rector reports places in the code where
@noRectoris still used, so you can avoid unwanted changes. But in mostly cases, the ignore will not be needed.