Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Dec 5, 2022

@samsonasik
Copy link
Member

The autoload just overlapped in rector-symfony, that can be tweaked by add the bootstrap via:

    $rectorConfig->bootstrapFiles([
        __DIR__ . '/vendor/phpstan/phpdoc-parser/src/Ast/Type/GenericTypeNode.php',
    ]);

in rector.php, see that rectorphp/rector-symfony#306 (comment) make CI green

@TomasVotruba
Copy link
Member Author

This is now breaking in every package. Untill new PHPStan is released, we need to use compatible phpdoc-parser here

@samsonasik
Copy link
Member

samsonasik commented Dec 5, 2022

Actually, the "preload.php" can be used like in here https://github.com/rectorphp/rector-src/blob/main/preload.php

Every packages can load it (with some enhancement) and it will working ok.

@TomasVotruba
Copy link
Member Author

Not necessary, we can wait for PHPStan release. There is nothing from phpdoc-parser 1.14 we use, right?

@TomasVotruba TomasVotruba merged commit b56440a into main Dec 5, 2022
@TomasVotruba TomasVotruba deleted the tv-lock-phpdoc-parser branch December 5, 2022 13:20
@samsonasik
Copy link
Member

Ok 👍

@samsonasik
Copy link
Member

@TomasVotruba The preload.php need to be regenerated.

@TomasVotruba
Copy link
Member Author

TomasVotruba commented Dec 5, 2022

I've removed it in wrong repo, should be fixed now:
3149ea4 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants