[TypeDeclaration] Remove PhpDocTypeChanger->changeVarType() on TypedPropertyFromAssignsRector

[samsonasik]

@TomasVotruba per discussion on #3161 (comment)

This PR remove PhpDocTypeChanger->changeVarType() without changing Property Type on TypedPropertyFromAssignsRector

The rule is also using:

$this->propertyTypeDecorator->decoratePropertyUnionType($inferredType, $typeNode, $node, $phpDocInfo);

which chaning both type and docblock, but as the service is used in multiple rules in vendor/, so I added $changeVarTypeFallback for it, so it is safer.

so the usage can be:

$this->propertyTypeDecorator->decoratePropertyUnionType($inferredType, $typeNode, $node, $phpDocInfo, false);

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

@TomasVotruba I added $changeVarTypeFallback flag param on PropertyTypeDecorator->decoratePropertyUnionType() as method re-use in vendor so it only apply typed strict on this rule only, as the method is used in vendor/ as well to avoid broken test in vendor.

[samsonasik]

I rolled back add $changeVarTypeFallback flag param on PropertyTypeDecorator->decoratePropertyUnionType() as it cause error in rules-tests

[samsonasik]

Not sure why suddently the rules-tests error:

There were 2 errors:

1) Rector\Tests\PSR4\Rector\FileWithoutNamespace\NormalizeNamespaceByPSR4ComposerAutoloadRector\NormalizeNamespaceByPSR4ComposerAutoloadRectorTest::test with data set #10 ('/home/runner/work/rector-src/...hp.inc')
Error: Object of class PhpParser\Node\Stmt\Namespace_ could not be converted to string

[samsonasik]

CI finally green again 🎉 , let's add back $changeVarTypeFallback flag param on PropertyTypeDecorator->decoratePropertyUnionType()

[samsonasik]

I added back $changeVarTypeFallback flag param on PropertyTypeDecorator->decoratePropertyUnionType() 46c7d73

[samsonasik]

Close-ReOpen to restart build.

[samsonasik]

Finally 🎉 All checks have passed 🎉 @TomasVotruba I think it is ready.

[TomasVotruba]

Thank you 👏