Do not apply property promotion to parameters with the SensitiveParameter attribute #3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Dec 7, 2022
...ssignToConstructorPromotionRector/Fixture/property_with_sensitiveparameter_attribute.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2022
...ssignToConstructorPromotionRector/Fixture/property_with_sensitiveparameter_attribute.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Dec 7, 2022
...ssignToConstructorPromotionRector/Fixture/property_with_sensitiveparameter_attribute.php.inc
Outdated
Show resolved
Hide resolved
…eter attribute Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
mbabker
force-pushed
the
no-promotion-for-sensitive-parameters
branch
from
6ad2efb to
612ba87
Compare
samsonasik
reviewed
Dec 7, 2022
rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
Outdated
Show resolved
Hide resolved
…otionRector.php Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
approved these changes
Dec 7, 2022
Member
|
Thank you 👏 |
|
FWIW: Putting the |
Member
|
The actual bug seems the Attribute removed during converting to property promotion, which should be kept, I will re-open the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7644