Skip to content

[Php82] Skip ReadOnlyClassRector on has parent non-readonly class #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 2 commits into from
Dec 7, 2022
Merged

[Php82] Skip ReadOnlyClassRector on has parent non-readonly class #3169

TomasVotruba merged 2 commits into from
Dec 7, 2022

Conversation

@Yoann-TYT
Copy link
Contributor

@Yoann-TYT Yoann-TYT commented Dec 7, 2022 •
edited by samsonasik
Loading

@Yoann-TYT Yoann-TYT changed the title Incorrect behavior of ReadOnlyPropertyRector, ReadOnlyClassRector #7646 Incorrect behavior of ReadOnlyPropertyRector, ReadOnlyClassRector Dec 7, 2022
@samsonasik
Copy link
Member

samsonasik commented Dec 7, 2022

Please update PR title to something like:

[Php82] Skip ReadOnlyClassRector on has parent non-readonly class

@samsonasik samsonasik changed the title Incorrect behavior of ReadOnlyPropertyRector, ReadOnlyClassRector [Php82] Skip ReadOnlyClassRector on has parent non-readonly class Dec 7, 2022
samsonasik
samsonasik approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I edited your PR title :)

@TomasVotruba TomasVotruba merged commit 84b54c0 into rectorphp:main Dec 7, 2022
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 7, 2022

Thanks 👍

@Yoann-TYT
Copy link
Contributor Author

Yoann-TYT commented Dec 7, 2022

@TomasVotruba and @samsonasik
Thanks for your quickly merge ! 🚀

@samsonasik samsonasik mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ReadOnlyPropertyRector, ReadOnlyClassRector

3 participants

@Yoann-TYT @samsonasik @TomasVotruba