Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 8, 2022

Instead of rely on this and self variable, use FullyQualifiedObjectType and ThisType instead, so unnecessary re-check current class usage on rules never needed.

For PropertyFetch inside trait, the PropertyFetch doesn't parent Node, so it still rely on this, self, static name as fallback.

@samsonasik samsonasik marked this pull request as draft December 8, 2022 06:20
@samsonasik samsonasik marked this pull request as ready for review December 8, 2022 06:37
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 2848e0d into main Dec 8, 2022
@TomasVotruba TomasVotruba deleted the allow-cloned-object-typed branch December 8, 2022 10:07
@TomasVotruba
Copy link
Member

Very nice improvement, thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants