[DeadCode] Skip Class Constant used in Enum on RemoveUnusedPrivateCla…

[eliashaeussler]

Based on https://getrector.org/demo/2333a008-e4b0-4d11-9ade-3b37412193d2

Fixes rectorphp/rector#7651

[samsonasik]

Could you try to provide a patch for it? It seems you can check on ClassConstManipulator by remove the following check:

rector-src/src/NodeManipulator/ClassConstManipulator.php

Lines 28 to 31 in 863fee3

	$class = $this->betterNodeFinder->findParentType($classConst, Class_::class);
	if (! $class instanceof Class_) {
	return false;
	}

-        $class = $this->betterNodeFinder->findParentType($classConst, Class_::class);
-        if (! $class instanceof Class_) {
-            return false;
-        }

since it already check on next $classReflection->getAncestors() which fallback to return false in the end.

[eliashaeussler]

@samsonasik Thanks for the hint, I'm already on it and will provide a fix soon.

[samsonasik]

After fix applied, please rename PR title to something like:

[DeadCode] Skip Class Constant used in Enum on RemoveUnusedPrivateClassConstantRector

[samsonasik]

Looks good 👍

[TomasVotruba]

Thanks 🙏