Skip to content

[Php80] Do not remove Parameter attribute on ClassPropertyAssignToConstructorPromotionRector #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 4 commits into from
Dec 10, 2022
Merged

[Php80] Do not remove Parameter attribute on ClassPropertyAssignToConstructorPromotionRector #3179

TomasVotruba merged 4 commits into from
Dec 10, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 10, 2022

@samsonasik
Copy link
Member Author

samsonasik commented Dec 10, 2022

Fixed 🎉 /cc @mbabker @TimWolla

@samsonasik
Copy link
Member Author

samsonasik commented Dec 10, 2022

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 44ebace into main Dec 10, 2022
@TomasVotruba TomasVotruba deleted the do-not-remove-param-attr-groups branch December 10, 2022 11:53
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 10, 2022

Thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ClassPropertyAssignToConstructorPromotionRector with SensitiveParameter attribute

4 participants

@samsonasik @TomasVotruba @actions-user