diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md index d127a71a793..afda9c8802d 100644 --- a/build/target-repository/docs/rector_rules_overview.md +++ b/build/target-repository/docs/rector_rules_overview.md @@ -7907,49 +7907,6 @@ return static function (RectorConfig $rectorConfig): void {
-### DimFetchAssignToMethodCallRector - -Change magic array access add to `$list[],` to explicit `$list->addMethod(...)` - -:wrench: **configure it!** - -- class: [`Rector\Transform\Rector\Assign\DimFetchAssignToMethodCallRector`](../rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php) - -```php -ruleWithConfiguration(DimFetchAssignToMethodCallRector::class, [ - new DimFetchAssignToMethodCall('Nette\Application\Routers\RouteList', 'Nette\Application\Routers\Route', 'addRoute'), - ]); -}; -``` - -↓ - -```diff --use Nette\Application\Routers\Route; - use Nette\Application\Routers\RouteList; - - class RouterFactory - { - public static function createRouter() - { - $routeList = new RouteList(); -- $routeList[] = new Route('...'); -+ $routeList->addRoute('...'); - } - } -``` - -
- ### FileGetContentsAndJsonDecodeToStaticCallRector Merge 2 function calls to static call diff --git a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/DimFetchAssignToMethodCallRectorTest.php b/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/DimFetchAssignToMethodCallRectorTest.php deleted file mode 100644 index a2d5b38ae43..00000000000 --- a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/DimFetchAssignToMethodCallRectorTest.php +++ /dev/null @@ -1,28 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/configured_rule.php'; - } -} diff --git a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Fixture/fixture.php.inc b/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Fixture/fixture.php.inc deleted file mode 100644 index 3b66ca0b572..00000000000 --- a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Fixture/fixture.php.inc +++ /dev/null @@ -1,37 +0,0 @@ -//[/]', 'Homepage:default'); - return $routeList; - } -} - -?> ------ -addRoute('//[/]', 'Homepage:default'); - return $routeList; - } -} - -?> diff --git a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Source/SomeRoute.php b/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Source/SomeRoute.php deleted file mode 100644 index be7442b223d..00000000000 --- a/rules-tests/Transform/Rector/Assign/DimFetchAssignToMethodCallRector/Source/SomeRoute.php +++ /dev/null @@ -1,10 +0,0 @@ -ruleWithConfiguration( - DimFetchAssignToMethodCallRector::class, - [new DimFetchAssignToMethodCall(SomeRouteList::class, SomeRoute::class, 'addRoute')] - ); -}; diff --git a/rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php b/rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php deleted file mode 100644 index 2375e6f9469..00000000000 --- a/rules/Transform/Rector/Assign/DimFetchAssignToMethodCallRector.php +++ /dev/null @@ -1,137 +0,0 @@ -addMethod(...)', - [ - new ConfiguredCodeSample( - <<<'CODE_SAMPLE' -use Nette\Application\Routers\Route; -use Nette\Application\Routers\RouteList; - -class RouterFactory -{ - public static function createRouter() - { - $routeList = new RouteList(); - $routeList[] = new Route('...'); - } -} -CODE_SAMPLE - , - <<<'CODE_SAMPLE' -use Nette\Application\Routers\RouteList; - -class RouterFactory -{ - public static function createRouter() - { - $routeList = new RouteList(); - $routeList->addRoute('...'); - } -} -CODE_SAMPLE - , - [ - new DimFetchAssignToMethodCall( - 'Nette\Application\Routers\RouteList', - 'Nette\Application\Routers\Route', - 'addRoute' - ), - ] - ), - ] - ); - } - - /** - * @return array> - */ - public function getNodeTypes(): array - { - return [Assign::class]; - } - - /** - * @param Assign $node - */ - public function refactor(Node $node): ?Node - { - if (! $node->var instanceof ArrayDimFetch) { - return null; - } - - $arrayDimFetch = $node->var; - if (! $arrayDimFetch->var instanceof Variable) { - return null; - } - - if (! $node->expr instanceof New_) { - return null; - } - - $dimFetchAssignToMethodCall = $this->findDimFetchAssignToMethodCall($node); - if (! $dimFetchAssignToMethodCall instanceof DimFetchAssignToMethodCall) { - return null; - } - - return new MethodCall($arrayDimFetch->var, $dimFetchAssignToMethodCall->getAddMethod(), $node->expr->args); - } - - /** - * @param mixed[] $configuration - */ - public function configure(array $configuration): void - { - Assert::allIsAOf($configuration, DimFetchAssignToMethodCall::class); - $this->dimFetchAssignToMethodCalls = $configuration; - } - - private function findDimFetchAssignToMethodCall(Assign $assign): ?DimFetchAssignToMethodCall - { - /** @var ArrayDimFetch $arrayDimFetch */ - $arrayDimFetch = $assign->var; - - foreach ($this->dimFetchAssignToMethodCalls as $dimFetchAssignToMethodCall) { - if (! $this->isObjectType($arrayDimFetch->var, $dimFetchAssignToMethodCall->getListObjectType())) { - continue; - } - - if (! $this->isObjectType($assign->expr, $dimFetchAssignToMethodCall->getItemObjectType())) { - continue; - } - - return $dimFetchAssignToMethodCall; - } - - return null; - } -} diff --git a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php b/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php deleted file mode 100644 index 55a8de4a901..00000000000 --- a/rules/Transform/ValueObject/DimFetchAssignToMethodCall.php +++ /dev/null @@ -1,34 +0,0 @@ -listClass); - } - - public function getItemObjectType(): ObjectType - { - return new ObjectType($this->itemClass); - } - - public function getAddMethod(): string - { - return $this->addMethod; - } -}