From a9e6e8321d5d73264a34169c6fd9305d885fe38c Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Thu, 7 Sep 2023 17:30:51 +0700 Subject: [PATCH 1/2] Add test fixture return docblock on init method call assign as skipped --- ...n_method_call_from_docblock_return.php.inc | 21 +++++++++++++++++++ .../Source/OrderRepositoryReturnDocblock.php | 12 +++++++++++ 2 files changed, 33 insertions(+) create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/skip_init_assign_method_call_from_docblock_return.php.inc create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/skip_init_assign_method_call_from_docblock_return.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/skip_init_assign_method_call_from_docblock_return.php.inc new file mode 100644 index 00000000000..2d08b67f07f --- /dev/null +++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Fixture/skip_init_assign_method_call_from_docblock_return.php.inc @@ -0,0 +1,21 @@ +fetchAllForBuyer(); + + foreach ($orders as $order) { + + } + + return $orders; + } +} diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php new file mode 100644 index 00000000000..72ad2361d5d --- /dev/null +++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php @@ -0,0 +1,12 @@ + Date: Thu, 7 Sep 2023 17:32:45 +0700 Subject: [PATCH 2/2] docblock --- .../Source/OrderRepositoryReturnDocblock.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php index 72ad2361d5d..9c8d81635d2 100644 --- a/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php +++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector/Source/OrderRepositoryReturnDocblock.php @@ -5,6 +5,9 @@ final class OrderRepositoryReturnDocblock { + /** + * @return array + */ public function fetchAllForBuyer() { return [];