From 66093cff6a95bd1dc05a19afe1662b02f63a4f09 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Wed, 17 Jan 2024 15:53:57 +0100 Subject: [PATCH] Deprecate Symfony level sets (#572) * deprecate Symfony level set list, for huge performance hit, conflicting rule order in various version * fixup! deprecate Symfony level set list, for huge performance hit, conflicting rule order in various version --- .../symfony/level/deprecated-level-set.php | 11 +++ .../sets/symfony/level/up-to-symfony-25.php | 10 --- .../sets/symfony/level/up-to-symfony-26.php | 11 --- .../sets/symfony/level/up-to-symfony-27.php | 11 --- .../sets/symfony/level/up-to-symfony-28.php | 11 --- .../sets/symfony/level/up-to-symfony-30.php | 11 --- .../sets/symfony/level/up-to-symfony-31.php | 11 --- .../sets/symfony/level/up-to-symfony-32.php | 11 --- .../sets/symfony/level/up-to-symfony-33.php | 11 --- .../sets/symfony/level/up-to-symfony-34.php | 11 --- .../sets/symfony/level/up-to-symfony-40.php | 11 --- .../sets/symfony/level/up-to-symfony-41.php | 11 --- .../sets/symfony/level/up-to-symfony-42.php | 11 --- .../sets/symfony/level/up-to-symfony-43.php | 11 --- .../sets/symfony/level/up-to-symfony-44.php | 11 --- .../sets/symfony/level/up-to-symfony-50.php | 13 ---- .../sets/symfony/level/up-to-symfony-51.php | 11 --- .../sets/symfony/level/up-to-symfony-52.php | 18 ----- .../sets/symfony/level/up-to-symfony-53.php | 11 --- .../sets/symfony/level/up-to-symfony-54.php | 11 --- .../sets/symfony/level/up-to-symfony-60.php | 11 --- .../sets/symfony/level/up-to-symfony-61.php | 11 --- .../sets/symfony/level/up-to-symfony-62.php | 11 --- .../sets/symfony/level/up-to-symfony-63.php | 11 --- .../sets/symfony/level/up-to-symfony-64.php | 11 --- src/Set/SymfonyLevelSetList.php | 73 +++++++++++++------ 26 files changed, 60 insertions(+), 296 deletions(-) create mode 100644 config/sets/symfony/level/deprecated-level-set.php delete mode 100644 config/sets/symfony/level/up-to-symfony-25.php delete mode 100644 config/sets/symfony/level/up-to-symfony-26.php delete mode 100644 config/sets/symfony/level/up-to-symfony-27.php delete mode 100644 config/sets/symfony/level/up-to-symfony-28.php delete mode 100644 config/sets/symfony/level/up-to-symfony-30.php delete mode 100644 config/sets/symfony/level/up-to-symfony-31.php delete mode 100644 config/sets/symfony/level/up-to-symfony-32.php delete mode 100644 config/sets/symfony/level/up-to-symfony-33.php delete mode 100644 config/sets/symfony/level/up-to-symfony-34.php delete mode 100644 config/sets/symfony/level/up-to-symfony-40.php delete mode 100644 config/sets/symfony/level/up-to-symfony-41.php delete mode 100644 config/sets/symfony/level/up-to-symfony-42.php delete mode 100644 config/sets/symfony/level/up-to-symfony-43.php delete mode 100644 config/sets/symfony/level/up-to-symfony-44.php delete mode 100644 config/sets/symfony/level/up-to-symfony-50.php delete mode 100644 config/sets/symfony/level/up-to-symfony-51.php delete mode 100644 config/sets/symfony/level/up-to-symfony-52.php delete mode 100644 config/sets/symfony/level/up-to-symfony-53.php delete mode 100644 config/sets/symfony/level/up-to-symfony-54.php delete mode 100644 config/sets/symfony/level/up-to-symfony-60.php delete mode 100644 config/sets/symfony/level/up-to-symfony-61.php delete mode 100644 config/sets/symfony/level/up-to-symfony-62.php delete mode 100644 config/sets/symfony/level/up-to-symfony-63.php delete mode 100644 config/sets/symfony/level/up-to-symfony-64.php diff --git a/config/sets/symfony/level/deprecated-level-set.php b/config/sets/symfony/level/deprecated-level-set.php new file mode 100644 index 00000000..4155f094 --- /dev/null +++ b/config/sets/symfony/level/deprecated-level-set.php @@ -0,0 +1,11 @@ +sets([SymfonySetList::SYMFONY_25]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-26.php b/config/sets/symfony/level/up-to-symfony-26.php deleted file mode 100644 index 3082e163..00000000 --- a/config/sets/symfony/level/up-to-symfony-26.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_26, SymfonyLevelSetList::UP_TO_SYMFONY_25]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-27.php b/config/sets/symfony/level/up-to-symfony-27.php deleted file mode 100644 index e4e98329..00000000 --- a/config/sets/symfony/level/up-to-symfony-27.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_27, SymfonyLevelSetList::UP_TO_SYMFONY_26]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-28.php b/config/sets/symfony/level/up-to-symfony-28.php deleted file mode 100644 index 7366a766..00000000 --- a/config/sets/symfony/level/up-to-symfony-28.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_28, SymfonyLevelSetList::UP_TO_SYMFONY_27]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-30.php b/config/sets/symfony/level/up-to-symfony-30.php deleted file mode 100644 index 1ef53da7..00000000 --- a/config/sets/symfony/level/up-to-symfony-30.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_30, SymfonyLevelSetList::UP_TO_SYMFONY_28]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-31.php b/config/sets/symfony/level/up-to-symfony-31.php deleted file mode 100644 index a5d82f25..00000000 --- a/config/sets/symfony/level/up-to-symfony-31.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_31, SymfonyLevelSetList::UP_TO_SYMFONY_30]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-32.php b/config/sets/symfony/level/up-to-symfony-32.php deleted file mode 100644 index c7cc461c..00000000 --- a/config/sets/symfony/level/up-to-symfony-32.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_32, SymfonyLevelSetList::UP_TO_SYMFONY_31]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-33.php b/config/sets/symfony/level/up-to-symfony-33.php deleted file mode 100644 index 0d3d1566..00000000 --- a/config/sets/symfony/level/up-to-symfony-33.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_33, SymfonyLevelSetList::UP_TO_SYMFONY_32]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-34.php b/config/sets/symfony/level/up-to-symfony-34.php deleted file mode 100644 index 109ee8b8..00000000 --- a/config/sets/symfony/level/up-to-symfony-34.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_34, SymfonyLevelSetList::UP_TO_SYMFONY_33]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-40.php b/config/sets/symfony/level/up-to-symfony-40.php deleted file mode 100644 index ee01fc58..00000000 --- a/config/sets/symfony/level/up-to-symfony-40.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_40, SymfonyLevelSetList::UP_TO_SYMFONY_34]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-41.php b/config/sets/symfony/level/up-to-symfony-41.php deleted file mode 100644 index 7ae6e985..00000000 --- a/config/sets/symfony/level/up-to-symfony-41.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_41, SymfonyLevelSetList::UP_TO_SYMFONY_40]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-42.php b/config/sets/symfony/level/up-to-symfony-42.php deleted file mode 100644 index 745cda8d..00000000 --- a/config/sets/symfony/level/up-to-symfony-42.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_42, SymfonyLevelSetList::UP_TO_SYMFONY_41]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-43.php b/config/sets/symfony/level/up-to-symfony-43.php deleted file mode 100644 index e39f0632..00000000 --- a/config/sets/symfony/level/up-to-symfony-43.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_43, SymfonyLevelSetList::UP_TO_SYMFONY_42]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-44.php b/config/sets/symfony/level/up-to-symfony-44.php deleted file mode 100644 index c3c5ba8b..00000000 --- a/config/sets/symfony/level/up-to-symfony-44.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_44, SymfonyLevelSetList::UP_TO_SYMFONY_43]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-50.php b/config/sets/symfony/level/up-to-symfony-50.php deleted file mode 100644 index 648e4b64..00000000 --- a/config/sets/symfony/level/up-to-symfony-50.php +++ /dev/null @@ -1,13 +0,0 @@ -sets( - [SymfonySetList::SYMFONY_50, SymfonySetList::SYMFONY_50_TYPES, SymfonyLevelSetList::UP_TO_SYMFONY_44] - ); -}; diff --git a/config/sets/symfony/level/up-to-symfony-51.php b/config/sets/symfony/level/up-to-symfony-51.php deleted file mode 100644 index 302c7f07..00000000 --- a/config/sets/symfony/level/up-to-symfony-51.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_51, SymfonyLevelSetList::UP_TO_SYMFONY_50]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-52.php b/config/sets/symfony/level/up-to-symfony-52.php deleted file mode 100644 index a1194253..00000000 --- a/config/sets/symfony/level/up-to-symfony-52.php +++ /dev/null @@ -1,18 +0,0 @@ -sets( - [ - SymfonySetList::SYMFONY_52, - SymfonySetList::SYMFONY_52_VALIDATOR_ATTRIBUTES, - SymfonySetList::ANNOTATIONS_TO_ATTRIBUTES, - SymfonyLevelSetList::UP_TO_SYMFONY_51, - ] - ); -}; diff --git a/config/sets/symfony/level/up-to-symfony-53.php b/config/sets/symfony/level/up-to-symfony-53.php deleted file mode 100644 index 599804e1..00000000 --- a/config/sets/symfony/level/up-to-symfony-53.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_53, SymfonyLevelSetList::UP_TO_SYMFONY_52]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-54.php b/config/sets/symfony/level/up-to-symfony-54.php deleted file mode 100644 index a89d2b4f..00000000 --- a/config/sets/symfony/level/up-to-symfony-54.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_54, SymfonyLevelSetList::UP_TO_SYMFONY_53]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-60.php b/config/sets/symfony/level/up-to-symfony-60.php deleted file mode 100644 index 0de1e02a..00000000 --- a/config/sets/symfony/level/up-to-symfony-60.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_60, SymfonyLevelSetList::UP_TO_SYMFONY_54]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-61.php b/config/sets/symfony/level/up-to-symfony-61.php deleted file mode 100644 index a6945cbe..00000000 --- a/config/sets/symfony/level/up-to-symfony-61.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_61, SymfonyLevelSetList::UP_TO_SYMFONY_60]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-62.php b/config/sets/symfony/level/up-to-symfony-62.php deleted file mode 100644 index 4343cc59..00000000 --- a/config/sets/symfony/level/up-to-symfony-62.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_62, SymfonyLevelSetList::UP_TO_SYMFONY_61]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-63.php b/config/sets/symfony/level/up-to-symfony-63.php deleted file mode 100644 index 7523a634..00000000 --- a/config/sets/symfony/level/up-to-symfony-63.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_63, SymfonyLevelSetList::UP_TO_SYMFONY_62]); -}; diff --git a/config/sets/symfony/level/up-to-symfony-64.php b/config/sets/symfony/level/up-to-symfony-64.php deleted file mode 100644 index b0d66ec3..00000000 --- a/config/sets/symfony/level/up-to-symfony-64.php +++ /dev/null @@ -1,11 +0,0 @@ -sets([SymfonySetList::SYMFONY_64, SymfonyLevelSetList::UP_TO_SYMFONY_63]); -}; diff --git a/src/Set/SymfonyLevelSetList.php b/src/Set/SymfonyLevelSetList.php index 3554d383..6c6748e1 100644 --- a/src/Set/SymfonyLevelSetList.php +++ b/src/Set/SymfonyLevelSetList.php @@ -7,127 +7,152 @@ use Rector\Set\Contract\SetListInterface; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @api */ final class SymfonyLevelSetList implements SetListInterface { /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_25 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-25.php'; + final public const UP_TO_SYMFONY_25 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_26 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-26.php'; + final public const UP_TO_SYMFONY_26 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_27 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-27.php'; + final public const UP_TO_SYMFONY_27 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_28 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-28.php'; + final public const UP_TO_SYMFONY_28 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_30 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-30.php'; + final public const UP_TO_SYMFONY_30 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_31 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-31.php'; + final public const UP_TO_SYMFONY_31 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_32 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-32.php'; + final public const UP_TO_SYMFONY_32 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_33 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-33.php'; + final public const UP_TO_SYMFONY_33 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_34 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-34.php'; + final public const UP_TO_SYMFONY_34 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_40 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-40.php'; + final public const UP_TO_SYMFONY_40 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_41 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-41.php'; + final public const UP_TO_SYMFONY_41 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_42 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-42.php'; + final public const UP_TO_SYMFONY_42 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_43 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-43.php'; + final public const UP_TO_SYMFONY_43 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_44 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-44.php'; + final public const UP_TO_SYMFONY_44 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_50 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-50.php'; + final public const UP_TO_SYMFONY_50 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_51 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-51.php'; + final public const UP_TO_SYMFONY_51 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_52 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-52.php'; + final public const UP_TO_SYMFONY_52 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_53 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-53.php'; + final public const UP_TO_SYMFONY_53 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_54 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-54.php'; + final public const UP_TO_SYMFONY_54 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_60 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-60.php'; + final public const UP_TO_SYMFONY_60 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_61 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-61.php'; + final public const UP_TO_SYMFONY_61 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_62 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-62.php'; + final public const UP_TO_SYMFONY_62 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_63 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-63.php'; + final public const UP_TO_SYMFONY_63 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; /** + * @deprecated Instead of too bloated and overriding level sets, use only latest Symfony set * @var string */ - final public const UP_TO_SYMFONY_64 = __DIR__ . '/../../config/sets/symfony/level/up-to-symfony-64.php'; + final public const UP_TO_SYMFONY_64 = __DIR__ . '/../../config/sets/symfony/level/deprecated-level-set.php'; }