Fix rule when method is __invoke #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
requested changes
Nov 25, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
The general magic is on purpose to avoid __construct included.
To ensure it only apply on __invoke only, use
\Rector\NodeAnalyzer\MagicClassMethodAnalyzer::isUnsafeOverridden() method, see
Contributor
Author
|
Nice, thank you for your feedback, I just commited to use |
samsonasik
approved these changes
Nov 25, 2025
Member
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When we use the magic
__invokemethod, theInlineClassRoutePrefixrule does not apply even though it should: https://getrector.com/demo/3caf4eca-9383-470b-be3a-a34e2f5adbc1I tried to fix it, feel free to review my changes.