From 4122e6756fd41f225652d63932182443c7303f06 Mon Sep 17 00:00:00 2001
From: Tomas Votruba <tomas.vot@gmail.com>
Date: Wed, 17 Apr 2019 13:24:49 +0200
Subject: [PATCH] [DeadCode] Skip magic methods in RemoveUnusedParameterRector
 [closes #1324]

---
 .../RemoveUnusedParameterRector.php           | 24 +++++++++++++++++
 .../Fixture/keep_magic_methods_param.php.inc  | 26 +++++++++++++++++++
 .../RemoveUnusedParameterRectorTest.php       |  1 +
 3 files changed, 51 insertions(+)
 create mode 100644 packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/keep_magic_methods_param.php.inc

diff --git a/packages/DeadCode/src/Rector/ClassMethod/RemoveUnusedParameterRector.php b/packages/DeadCode/src/Rector/ClassMethod/RemoveUnusedParameterRector.php
index d2a4fefc84e7..29206648317b 100644
--- a/packages/DeadCode/src/Rector/ClassMethod/RemoveUnusedParameterRector.php
+++ b/packages/DeadCode/src/Rector/ClassMethod/RemoveUnusedParameterRector.php
@@ -28,6 +28,26 @@ final class RemoveUnusedParameterRector extends AbstractRector
      */
     private $classMethodManipulator;
 
+    /**
+     * @var string[]
+     */
+    private $magicMethods = [
+        '__call',
+        '__callStatic',
+        '__clone',
+        '__debugInfo',
+        '__destruct',
+        '__get',
+        '__invoke',
+        '__isset',
+        '__set',
+        '__set_state',
+        '__sleep',
+        '__toString',
+        '__unset',
+        '__wakeup',
+    ];
+
     public function __construct(ClassManipulator $classManipulator, ClassMethodManipulator $classMethodManipulator)
     {
         $this->classManipulator = $classManipulator;
@@ -83,6 +103,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($this->isNames($node, $this->magicMethods)) {
+            return null;
+        }
+
         $class = $this->getName($classNode);
         if ($class === null) {
             return null;
diff --git a/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/keep_magic_methods_param.php.inc b/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/keep_magic_methods_param.php.inc
new file mode 100644
index 000000000000..9e9ad2e7141b
--- /dev/null
+++ b/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/Fixture/keep_magic_methods_param.php.inc
@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\DeadCode\Tests\Rector\ClassMethod\RemoveUnusedParameterRector\Fixture;
+
+class SomeClassWithMagicMethods
+{
+    public function __call($one, $two)
+    {
+    }
+
+    public function __get($one)
+    {
+    }
+
+    public function __set($one, $value)
+    {
+    }
+
+    public function __isset($one)
+    {
+    }
+
+    public static function __callStatic($one, $two)
+    {
+    }
+}
diff --git a/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/RemoveUnusedParameterRectorTest.php b/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/RemoveUnusedParameterRectorTest.php
index 672c5df7ab7e..942aa1e6d5b3 100644
--- a/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/RemoveUnusedParameterRectorTest.php
+++ b/packages/DeadCode/tests/Rector/ClassMethod/RemoveUnusedParameterRector/RemoveUnusedParameterRectorTest.php
@@ -15,6 +15,7 @@ public function test(): void
             __DIR__ . '/Fixture/parent_required.php.inc',
             __DIR__ . '/Fixture/in_between_parameter.php.inc',
             __DIR__ . '/Fixture/compact.php.inc',
+            __DIR__ . '/Fixture/keep_magic_methods_param.php.inc',
         ]);
     }