From c9d96c9cb0ffbd132f810cc6f66fe415a8c8be45 Mon Sep 17 00:00:00 2001
From: Christian Scheb <privat@stylemotion.de>
Date: Mon, 19 Aug 2019 23:24:55 +0200
Subject: [PATCH] Test case to demonstrate how refactoring order creates
 incompatible return types

---
 .../CovarianceTest.php                        |  1 +
 .../inheritance_covariance_order.php.inc      | 49 +++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/Fixture/nikic/inheritance_covariance_order.php.inc

diff --git a/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/CovarianceTest.php b/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/CovarianceTest.php
index b94afb56a3e1..c985e925c6b7 100644
--- a/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/CovarianceTest.php
+++ b/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/CovarianceTest.php
@@ -21,6 +21,7 @@ public function test(string $file): void
     public function provideDataForTest(): iterable
     {
         yield [__DIR__ . '/Fixture/nikic/inheritance_covariance.php.inc'];
+        yield [__DIR__ . '/Fixture/nikic/inheritance_covariance_order.php.inc'];
         yield [__DIR__ . '/Fixture/Covariance/return_interface_to_class.php.inc'];
         yield [__DIR__ . '/Fixture/Covariance/return_nullable_with_parent_interface.php.inc'];
     }
diff --git a/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/Fixture/nikic/inheritance_covariance_order.php.inc b/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/Fixture/nikic/inheritance_covariance_order.php.inc
new file mode 100644
index 000000000000..a93c3a0c15ca
--- /dev/null
+++ b/packages/TypeDeclaration/tests/Rector/FunctionLike/ReturnTypeDeclarationRector/Fixture/nikic/inheritance_covariance_order.php.inc
@@ -0,0 +1,49 @@
+<?php
+
+namespace Rector\TypeDeclaration\Tests\Rector\ClassMethod\ReturnTypeDeclarationRector\Fixture\InheritanceOrder;
+
+class CCovariance extends ACovariance {
+    /**
+     * Technically valid return type, but against PHP's variance restrictions.
+     * We use "ACovariance" instead, which is less accurate but valid.
+     *
+     * @return CCovariance
+     */
+    public function test() {
+        return $this;
+    }
+}
+
+class ACovariance {
+    /** @return ACovariance */
+    public function test() {
+        return $this;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\TypeDeclaration\Tests\Rector\ClassMethod\ReturnTypeDeclarationRector\Fixture\InheritanceOrder;
+
+class CCovariance extends ACovariance {
+    /**
+     * Technically valid return type, but against PHP's variance restrictions.
+     * We use "ACovariance" instead, which is less accurate but valid.
+     *
+     * @return CCovariance
+     */
+    public function test(): \Rector\TypeDeclaration\Tests\Rector\ClassMethod\ReturnTypeDeclarationRector\Fixture\InheritanceOrder\ACovariance {
+        return $this;
+    }
+}
+
+class ACovariance {
+    /** @return ACovariance */
+    public function test(): self {
+        return $this;
+    }
+}
+
+?>